Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-adding legacy proposal type for ibc client upgrades #4732

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Sep 20, 2023

Description

ref: #4721


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

Codecov Report

Merging #4732 (1faa601) into main (32560f4) will decrease coverage by 0.29%.
The diff coverage is 2.04%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4732      +/-   ##
==========================================
- Coverage   79.77%   79.48%   -0.29%     
==========================================
  Files         189      189              
  Lines       13231    13280      +49     
==========================================
+ Hits        10555    10556       +1     
- Misses       2248     2296      +48     
  Partials      428      428              
Files Changed Coverage Δ
modules/core/02-client/types/legacy_proposal.go 35.06% <2.04%> (-57.80%) ⬇️

@@ -3,20 +3,34 @@
package types

import (
"fmt"
"reflect"

Check notice

Code scanning / CodeQL

Sensitive package import Note

Certain system packages contain functions which may be a possible source of non-determinism
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@damiannolan damiannolan enabled auto-merge (squash) September 21, 2023 07:40
@damiannolan damiannolan enabled auto-merge (squash) September 21, 2023 07:40
@damiannolan damiannolan merged commit bef00ef into main Sep 21, 2023
14 of 18 checks passed
@damiannolan damiannolan deleted the damian/legacy-gov-2 branch September 21, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants