Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): get next send sequence for transfer packets #4706

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

dzmitry-lahoda
Copy link
Contributor

Description

closes: #4698

Commit Message / Changelog Entry

feat(packet): get next send sequence for transfer packets

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@dzmitry-lahoda
Copy link
Contributor Author

what else should I do?

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dzmitry-lahoda. It would be good to fix this test. You can do something like it is done in this other test for ordered channels, where the next sequence send is set and then the test check that the query returns the expected value.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @dzmitry-lahoda!

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #4706 (50e3edc) into main (3db1681) will increase coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4706      +/-   ##
==========================================
+ Coverage   79.65%   79.69%   +0.03%     
==========================================
  Files         187      187              
  Lines       13195    13186       -9     
==========================================
- Hits        10511    10508       -3     
+ Misses       2253     2248       -5     
+ Partials      431      430       -1     
Files Changed Coverage Δ
modules/core/04-channel/keeper/grpc_query.go 86.46% <100.00%> (+1.17%) ⬆️

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dzmitry-lahoda! I think we can remove the check on the channel lookup

modules/core/04-channel/keeper/grpc_query.go Outdated Show resolved Hide resolved
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dzmitry-lahoda! LGTM 🚀

@damiannolan damiannolan changed the title feat(packet): get next send sequence for transfer packets fix(query): get next send sequence for transfer packets Sep 19, 2023
@damiannolan damiannolan added core gRPC Issues for gRPC endpoints labels Sep 19, 2023
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dzmitry-lahoda for the issue and the fix! :)

@colin-axner
Copy link
Contributor

It looks like the pr will need to be brought up to date with main, if you allow maintainers write access (usually a button you can click on the side), we can manage this for you

@damiannolan damiannolan enabled auto-merge (squash) September 19, 2023 15:08
@damiannolan damiannolan merged commit cd25f88 into cosmos:main Sep 19, 2023
55 checks passed
@josietyleung
Copy link

@damiannolan
Copy link
Member

@colin-axner @damiannolan will this be included in v8 of ibc go? thanks https://github.com/cosmos/ibc-go/blob/main/docs/docs/01-ibc/09-roadmap.md

Hey @josietyleung, yes it will be included in the v8 release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core gRPC Issues for gRPC endpoints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why Query/NextSequenceSend is not available for UNORDERED channels?
6 participants