Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add compiler assertions for capability module #4654

Merged
merged 8 commits into from
Sep 14, 2023

Conversation

colin-axner
Copy link
Contributor

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@@ -27,8 +27,11 @@ import (
)

var (
_ module.AppModule = (*AppModule)(nil)
_ module.AppModuleBasic = (*AppModuleBasic)(nil)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can safely remove this assertion and the associated functions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because AppModule is AppModuleBasic :D makes sense!

@colin-axner colin-axner added the v8 label Sep 13, 2023
@damiannolan damiannolan requested a review from srdtrk September 14, 2023 09:47
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colin-axner colin-axner merged commit acfe815 into main Sep 14, 2023
59 checks passed
@colin-axner colin-axner deleted the colin/capability-compiler-assertions branch September 14, 2023 17:07
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
* chore: add compiler assertions for capability module

* chore: add HasGenesis assertion

(cherry picked from commit acfe815)

# Conflicts:
#	modules/capability/module.go
damiannolan added a commit that referenced this pull request Sep 18, 2023
…#4664)

* chore: add compiler assertions for capability module (#4654)

* chore: add compiler assertions for capability module

* chore: add HasGenesis assertion

(cherry picked from commit acfe815)

# Conflicts:
#	modules/capability/module.go

* chore: resolve conflicts, bump sdk to latest commit to fix HasGenesis interface

---------

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants