-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add compiler assertions for capability module #4654
Conversation
@@ -27,8 +27,11 @@ import ( | |||
) | |||
|
|||
var ( | |||
_ module.AppModule = (*AppModule)(nil) | |||
_ module.AppModuleBasic = (*AppModuleBasic)(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can safely remove this assertion and the associated functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because AppModule
is AppModuleBasic
:D makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* chore: add compiler assertions for capability module * chore: add HasGenesis assertion (cherry picked from commit acfe815) # Conflicts: # modules/capability/module.go
…#4664) * chore: add compiler assertions for capability module (#4654) * chore: add compiler assertions for capability module * chore: add HasGenesis assertion (cherry picked from commit acfe815) # Conflicts: # modules/capability/module.go * chore: resolve conflicts, bump sdk to latest commit to fix HasGenesis interface --------- Co-authored-by: colin axnér <[email protected]> Co-authored-by: Damian Nolan <[email protected]>
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.