Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update module path #4578

Closed
wants to merge 8 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 5, 2023

Description

closes: #4377

This PR updates the module paths for v8

Commit Message / Changelog Entry

chore: update module paths for v8

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@faddat faddat force-pushed the faddat/update-module-path branch from 3e46023 to 0415eb0 Compare September 6, 2023 02:53
@faddat faddat marked this pull request as ready for review September 6, 2023 02:53
@faddat
Copy link
Contributor Author

faddat commented Sep 6, 2023

e2e tests are expected to fail in this PR, but I'm ready to make another PR to interchaintest to update the paths for interchaintest as soon as this is merged.

@faddat faddat mentioned this pull request Sep 6, 2023
9 tasks
@damiannolan damiannolan self-assigned this Sep 6, 2023
@damiannolan
Copy link
Contributor

e2e tests are expected to fail in this PR, but I'm ready to make another PR to interchaintest to update the paths for interchaintest as soon as this is merged.

This sounds good to me! I'd be happy to merge this PR and get a v8.0.0-alpha0 tagged with the correct version suffix. Interchaintest can then point to that and get a commit/tag which we can then consume.

@damiannolan
Copy link
Contributor

I've updated interchaintest dep to latest on your fork: notional-labs/interchaintest@c2dc240

I've also commented out intertx e2e test code which I'll handle separately in some follow ups.

@colin-axner
Copy link
Contributor

Just a heads up we are opening a new pr, we needed to push over the referenced branch so that the bump in interchaintest could reference these changes. We will add you @faddat as a coauthor when merging the commit

Will close this pr if the other pr passes ci, thanks for starting this work!

@colin-axner
Copy link
Contributor

fixed by #4590!

@colin-axner colin-axner closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump package to v8
3 participants