feat: add proposal simulator interface function and tests #4466

charleenfei · 2023-08-25T15:58:22Z

Description

closes: #3151

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md).
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards and Go style guide.
Wrote unit and integration tests.
Updated relevant documentation (docs/) or specification (x/<module>/spec/).
Added relevant godoc comments.
Provide a commit message to be used for the changelog entry in the PR description for review.
Re-reviewed Files changed in the Github PR explorer.
Review Codecov Report in the comment section below once CI passes.

modules/apps/27-interchain-accounts/simulation/proposals.go

DimitrisJim · 2023-08-31T08:56:40Z

modules/apps/27-interchain-accounts/simulation/proposals.go

+// Simulation operation weights constants
+const (
+	DefaultWeightMsgUpdateParams int = 100
+	OpWeightMsgUpdateParams          = "op_weight_msg_update_params" // #nosec


is // #nosec a directive of sorts? any clue?

yea, i had to add it bc otherwise the linter thought i was sharing secrets 🙃

that's a yikes from me

damiannolan

Nice! Looks good, do we need to add these for transfer? or they are already there?

charleenfei · 2023-09-04T15:28:00Z

aha, i forgot about the UpdateParams gov-gated transfer message. will update this PR!

…-interface-function

crodriguezvega

Thanks, @charleenfei. Left a couple of questions.❓

crodriguezvega · 2023-09-06T20:53:15Z

modules/apps/27-interchain-accounts/simulation/proposals.go

+func SimulateMsgUpdateParams(r *rand.Rand, _ sdk.Context, _ []simtypes.Account) sdk.Msg {
+	var authority sdk.AccAddress = address.Module("gov")
+	params := types.DefaultParams()
+	params.HostEnabled = false


Should we randomise this value as SDK does?

sure, we can do this! I guess I just wanted to keep it one value to make testing easier 😅

opened this tracking issue

I think the purpose of simulations is that it performs random operations, we don't utilize simulations so this is mostly for chains which run sdk simulations

modules/apps/transfer/simulation/proposals.go

modules/apps/27-interchain-accounts/simulation/proposals.go

modules/core/simulation/proposals.go

…-interface-function

crodriguezvega

Nice work. Thank you, @charleenfei.

colin-axner

LGTM, thanks @charleenfei

colin-axner · 2023-09-07T14:23:31Z

modules/apps/27-interchain-accounts/simulation/proposals.go

+func SimulateMsgUpdateParams(r *rand.Rand, _ sdk.Context, _ []simtypes.Account) sdk.Msg {
+	var authority sdk.AccAddress = address.Module("gov")
+	params := types.DefaultParams()
+	params.HostEnabled = false


I think the purpose of simulations is that it performs random operations, we don't utilize simulations so this is mostly for chains which run sdk simulations

colin-axner · 2023-09-07T14:37:07Z

this can target main? unless you are planning on adding the new proposal msg types as well?

…and `MsgIBCSoftwareUpgrade`. The legacy proposal types `ClientUpdateProposal` and `UpgradeClientProposal` have been removed. (#4620) * Add proto message, implement sdk.Msg for Recover Client. (#4494) * Add proto message for Recover client, implement sdk.Message interface. * Update modules/core/02-client/types/msgs.go Co-authored-by: Damian Nolan <[email protected]> * Apply suggestions from code review Co-authored-by: Charly <[email protected]> * Remove gogoproto false for cmp, lint, move ibctesting address inline. --------- Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Charly <[email protected]> * add protos, msgs, keeper handler to upgrade clients using v1 governance proposals (#4436) * add protos and keeper function placeholder * add keeper functions/tests, msgs and tests * update to 0.47.5 release branch * Move signer as last proto field. (#4510) * msg server function and tests for MsgScheduleIBCClientUpgrade (#4442) * Add 02-client implementation for Recover client. (#4499) * Add 02-client implementation for Recover client. * Partially address feedback. * Docu RecoverClient, add label, re-use error. * Add implementation for recover client on message server. (#4503) * Add message server handler for recovering a client * Don't assign to deprecated attrs, clean up unused fields. * Further clean-up, remove declaration of unmutated vars. * Add cmd for submitting a recover client prop. (#4522) * Add cmd for submitting a recover client prop. * Bump cosmossdk in e2e. * Use govtypes.ModuleName, rename old govtypes to govv1beta1 * Update modules/core/02-client/client/cli/tx.go Co-authored-by: Damian Nolan <[email protected]> * Add auth flag. --------- Co-authored-by: Damian Nolan <[email protected]> * rename command * docs: fixed broken links (#4571) * Add e2e test for recovering a client. (#4543) Co-authored-by: Colin Axnér <[email protected]> * feat: add unpacket inerfaces message assertion (#4588) * add cli for MsgIBCSoftwareUpgrade (#4558) * docs: use MsgRecoverClient in docs (#4580) * docs: recover client update * Update docs/ibc/proposals.md * Apply suggestions from code review Co-authored-by: Carlos Rodriguez <[email protected]> --------- Co-authored-by: Carlos Rodriguez <[email protected]> * refactor: remove legacy client update proposal (#4581) * refactor: remove legacy client update proposal * e2e: swap from ClientUpdateProposal e2e to RecoverClient * refactor: remove unused events * feat: add proposal simulator interface function and tests (#4466) Co-authored-by: colin axner <[email protected]> * refactor!: remove UpgradeProposal type (#4602) * create separate event emission for ibc software upgrades vs an upgraded client (#4594) * add new event type * update event name * fix build * remove: legacy event emissions * remove: unnecessary assignments, apply suggestion from code review * e2e: schedule IBC software upgrade (#4585) * wip e2e test * query proposal * update upgrade height in plan * rm unnecessary wait/authority * rm test artifact from merge * add checks for scheduled plan * hook up upgrade query client * plan height * pr fixes * update test * import space * update newchainID value * update clientID upgrade * linter * gci * rm unnecessary event --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: colin axnér <[email protected]> Co-authored-by: Sishir Giri <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Jim Fasarakis-Hilliard <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: catShaark <[email protected]> Co-authored-by: khanh-notional <[email protected]> * chore: docs for MsgIBCSoftwareUpgrade (#4601) * chore: update docs for UpgradeProposal -> MsgIBCSoftwareUpgrade * chore: anticipate link change * fix event docs * refactor: s.Assert -> s.Require * Apply suggestions from code review Co-authored-by: Damian Nolan <[email protected]> * make proto-all * chore: update compiler assertion * refactor: ordering, order as follows: create, update, upgrade, misbheaviour, recover, ibcsoftwareupgrade, update params * refactor: simplify ibc software upgrade emitted event * lint lint lint * Apply suggestions from code review Co-authored-by: Charly <[email protected]> * review of feat/govv1 * pr nits * fix tests for error wrapping --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jim Fasarakis-Hilliard <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Charly <[email protected]> Co-authored-by: Charly <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: srdtrk <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sishir Giri <[email protected]> Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: catShaark <[email protected]> Co-authored-by: khanh-notional <[email protected]>

charleenfei added the v8 label Aug 25, 2023

charleenfei marked this pull request as ready for review August 28, 2023 12:11

charleenfei requested review from colin-axner, AdityaSripal and damiannolan as code owners August 28, 2023 12:11

colin-axner reviewed Aug 30, 2023

View reviewed changes

modules/apps/27-interchain-accounts/simulation/proposals.go Show resolved Hide resolved

DimitrisJim reviewed Aug 31, 2023

View reviewed changes

charleenfei added 3 commits September 1, 2023 13:46

add proposal simulator and tests

68bc3c1

linter

5c1c655

call proposal sim function from appmodule

3aac9c1

charleenfei force-pushed the charly/issue#3151-support-proposalmsgs-interface-function branch from 95e4ff5 to 3aac9c1 Compare September 1, 2023 11:48

charleenfei requested review from crodriguezvega and chatton as code owners September 1, 2023 11:48

charleenfei changed the base branch from main to feat/govv1 September 1, 2023 11:49

damiannolan reviewed Sep 4, 2023

View reviewed changes

charleenfei marked this pull request as draft September 4, 2023 15:28

add transfer sim proposal

771e438

charleenfei marked this pull request as ready for review September 5, 2023 12:46

Merge branch 'feat/govv1' into charly/issue#3151-support-proposalmsgs…

7a3468f

…-interface-function

crodriguezvega reviewed Sep 6, 2023

View reviewed changes

charleenfei mentioned this pull request Sep 7, 2023

refactor: look into randomising values in proposal simulation tests #4595

Closed

charleenfei added 4 commits September 7, 2023 14:20

update per pr comments

75d6a17

Merge branch 'feat/govv1' into charly/issue#3151-support-proposalmsgs…

00ec02d

…-interface-function

update authority -> signer

9c44bdf

linter

e8fd92e

crodriguezvega approved these changes Sep 7, 2023

View reviewed changes

colin-axner added 2 commits September 7, 2023 16:18

chore: add compiler assertions for module.HasProposalMsgs

5eac14c

fix: correct compiler assertion for HasProposalMsgs

1c2fae1

colin-axner approved these changes Sep 7, 2023

View reviewed changes

charleenfei mentioned this pull request Sep 7, 2023

add proposal simulations for MsgRecoverClient and MsgIBCSoftwareUpgrade #4599

Closed

3 tasks

charleenfei merged commit c4f947e into feat/govv1 Sep 7, 2023
50 checks passed

charleenfei deleted the charly/issue#3151-support-proposalmsgs-interface-function branch September 7, 2023 15:09

charleenfei restored the charly/issue#3151-support-proposalmsgs-interface-function branch September 7, 2023 15:09

charleenfei deleted the charly/issue#3151-support-proposalmsgs-interface-function branch September 7, 2023 15:10

colin-axner mentioned this pull request Sep 13, 2023

[Feature]: Add compiler assertions to UPGRADING doc for v0.50 cosmos/cosmos-sdk#17715

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add proposal simulator interface function and tests #4466

feat: add proposal simulator interface function and tests #4466

charleenfei commented Aug 25, 2023

DimitrisJim Aug 31, 2023

charleenfei Aug 31, 2023

damiannolan Sep 4, 2023 •

edited

Loading

chatton Sep 5, 2023

damiannolan left a comment

charleenfei commented Sep 4, 2023

crodriguezvega left a comment

crodriguezvega Sep 6, 2023

charleenfei Sep 7, 2023 •

edited

Loading

charleenfei Sep 7, 2023

colin-axner Sep 7, 2023

crodriguezvega left a comment

colin-axner left a comment

colin-axner Sep 7, 2023

colin-axner commented Sep 7, 2023

feat: add proposal simulator interface function and tests #4466

feat: add proposal simulator interface function and tests #4466

Conversation

charleenfei commented Aug 25, 2023

Description

DimitrisJim Aug 31, 2023

Choose a reason for hiding this comment

charleenfei Aug 31, 2023

Choose a reason for hiding this comment

damiannolan Sep 4, 2023 • edited Loading

Choose a reason for hiding this comment

chatton Sep 5, 2023

Choose a reason for hiding this comment

damiannolan left a comment

Choose a reason for hiding this comment

charleenfei commented Sep 4, 2023

crodriguezvega left a comment

Choose a reason for hiding this comment

crodriguezvega Sep 6, 2023

Choose a reason for hiding this comment

charleenfei Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

charleenfei Sep 7, 2023

Choose a reason for hiding this comment

colin-axner Sep 7, 2023

Choose a reason for hiding this comment

crodriguezvega left a comment

Choose a reason for hiding this comment

colin-axner left a comment

Choose a reason for hiding this comment

colin-axner Sep 7, 2023

Choose a reason for hiding this comment

colin-axner commented Sep 7, 2023

damiannolan Sep 4, 2023 •

edited

Loading

charleenfei Sep 7, 2023 •

edited

Loading