Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg server function and tests for MsgScheduleIBCClientUpgrade #4442

Merged
merged 35 commits into from
Aug 30, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
f9ce4fd
add protos and keeper function placeholder
charleenfei Aug 22, 2023
5242278
add keeper functions/tests, msgs and tests
charleenfei Aug 23, 2023
f499db4
fix linter
charleenfei Aug 23, 2023
59514fe
bring back msg_server placeholders
charleenfei Aug 23, 2023
55eb017
add msg_server function and tests
charleenfei Aug 23, 2023
a4922e7
fix linter
charleenfei Aug 23, 2023
8c4ca90
Merge branch 'charly/issue#3673-add-message-and-rpc-handler-to-upgrad…
charleenfei Aug 23, 2023
70a431f
update msg name, make changes in testing
charleenfei Aug 24, 2023
22125d3
Merge branch 'charly/issue#3673-add-message-and-rpc-handler-to-upgrad…
charleenfei Aug 24, 2023
314c81d
fix linter, update to new msg name
charleenfei Aug 24, 2023
b2eee55
update test bool, method name
charleenfei Aug 28, 2023
2c94f5f
capitalisation
charleenfei Aug 28, 2023
6d7407b
Merge branch 'charly/issue#3673-add-message-and-rpc-handler-to-upgrad…
charleenfei Aug 28, 2023
5b4aa3c
update test bool
charleenfei Aug 28, 2023
5462ba6
update testcase
charleenfei Aug 28, 2023
f23b9b4
Merge branch 'charly/issue#3673-add-message-and-rpc-handler-to-upgrad…
charleenfei Aug 28, 2023
776a7ce
added check that message implements sdk.Msg interface
Aug 29, 2023
efa5e43
update authority -> signers
charleenfei Aug 29, 2023
dbbf6b9
Merge branch 'feat/govv1' into charly/issue#3673-add-message-and-rpc-…
charleenfei Aug 29, 2023
eb99d94
merge
charleenfei Aug 29, 2023
77a2720
fix merge conflicts
charleenfei Aug 29, 2023
9744005
Merge branch 'charly/issue#3673-add-message-and-rpc-handler-to-upgrad…
charleenfei Aug 29, 2023
7868ed2
update authority -> signer
charleenfei Aug 29, 2023
d5d5dcb
add tests back in
charleenfei Aug 29, 2023
c418302
fix merge shenanigans
charleenfei Aug 29, 2023
4cad828
add check for tm client type
charleenfei Aug 29, 2023
89da39e
msgs
charleenfei Aug 29, 2023
3de8fd5
Merge branch 'feat/govv1' into charly/issue#3673-msg-server
charleenfei Aug 29, 2023
c92a408
move params tests back to reduce diffs
charleenfei Aug 29, 2023
f4cd006
merge shenanigans
charleenfei Aug 29, 2023
49655cc
update tests per comments
charleenfei Aug 29, 2023
0505634
linter fix
charleenfei Aug 29, 2023
c4c033d
Merge branch 'feat/govv1' into charly/issue#3673-msg-server
charleenfei Aug 30, 2023
0125cdc
go mod tidy
charleenfei Aug 30, 2023
d7ff43a
pr comments
charleenfei Aug 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update authority -> signer
  • Loading branch information
charleenfei committed Aug 29, 2023
commit 7868ed2cbf75baf98652f03664b41d7a2ba6495d
4 changes: 2 additions & 2 deletions modules/core/keeper/msg_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -716,8 +716,8 @@ func (k Keeper) UpdateClientParams(goCtx context.Context, msg *clienttypes.MsgUp

// IBCSoftwareUpgrade defines a rpc handler method for MsgIBCSoftwareUpgrade.
func (k Keeper) IBCSoftwareUpgrade(goCtx context.Context, msg *clienttypes.MsgIBCSoftwareUpgrade) (*clienttypes.MsgIBCSoftwareUpgradeResponse, error) {
if k.GetAuthority() != msg.Authority {
return nil, errorsmod.Wrapf(ibcerrors.ErrUnauthorized, "expected %s, got %s", k.GetAuthority(), msg.Authority)
if k.GetAuthority() != msg.Signer {
return nil, errorsmod.Wrapf(ibcerrors.ErrUnauthorized, "expected %s, got %s", k.GetAuthority(), msg.Signer)
}

ctx := sdk.UnwrapSDKContext(goCtx)
Expand Down
2 changes: 1 addition & 1 deletion modules/core/keeper/msg_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,7 @@ func (suite *KeeperTestSuite) TestIBCSoftwareUpgrade() {
{
"failure: invalid authority address",
func() {
msg.Authority = suite.chainA.SenderAccount.GetAddress().String()
msg.Signer = suite.chainA.SenderAccount.GetAddress().String()
expError = ibcerrors.ErrUnauthorized
},
},
Expand Down