testing: e2e support for sdkv50 #4174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4580f76.
…o ibc-go-sdk-50-mark-2
faddat
requested review from
AdityaSripal,
charleenfei,
colin-axner,
damiannolan,
crodriguezvega,
chatton and
DimitrisJim
as code owners
DimitrisJim
reviewed
Aug 28, 2023
| @@ -271,8 +271,8 @@ func (s *E2ETestSuite) QueryProposalV1(ctx context.Context, chain ibc.Chain, pro | |||
|
|
|||
| // GetBlockHeaderByHeight fetches the block header at a given height. | |||
| func (s *E2ETestSuite) GetBlockHeaderByHeight(ctx context.Context, chain ibc.Chain, height uint64) (Header, error) { | |||
| cmtservice := s.GetChainGRCPClients(chain).ConsensusServiceClient | |||
| res, err := cmtservice.GetBlockByHeight(ctx, &ccmtservice.GetBlockByHeightRequest{ | |||
| ccmtservice := s.GetChainGRCPClients(chain).ConsensusServiceClient | |||
There was a problem hiding this comment.
are the diffs here just for the rename? any reason why we do them?
There was a problem hiding this comment.
ah, conflicts with the import for the client I'd guess "github.com/cosmos/cosmos-sdk/client/grpc/cmtservice" and linter is muy triste about it, leaving comment here so others don't ask same thing
colin-axner
reviewed
Aug 28, 2023
Comment on lines
-294
to
-295
| // GetExpectedEvent returns the expected event for a callback. | ||
| func GetExpectedEvent( |
There was a problem hiding this comment.
I think this should be added back, looks like maybe it got removed accidentally?
There was a problem hiding this comment.
is it actually being used anywhere?
There was a problem hiding this comment.
Yea, I will add back. The usage was deleted :)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins work to make the e2e tests support sdk 50,
based on this PR to interchaintest:
strangelove-ventures/interchaintest#674