imp: disallow submessage execution #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
crodriguezvega
commented
Jul 19, 2023
| @@ -261,5 +261,8 @@ func call[T ContractResult](ctx sdk.Context, clientStore sdk.KVStore, cs *Client | |||
| if !output.Validate() { | |||
| return output, errorsmod.Wrapf(errors.New(output.Error()), "error occurred while calling contract with code ID %s", hex.EncodeToString(cs.CodeId)) | |||
| } | |||
| if len(out.Messages) > 0 { | |||
| return output, errorsmod.Wrapf(ErrWasmSubMessagesNotAllowed, "code hash (%s)", hex.EncodeToString(cs.CodeId)) | |||
There was a problem hiding this comment.
I mention code hash in the message, assuming that this PR will eventually get merged.
There was a problem hiding this comment.
The var naming of out doesn't really feel intuitive to me, but we can rename it to whatever later, also maybe we could add something like this in a future improvement - handleContractResponse() ref
crodriguezvega
changed the title
DimitrisJim
approved these changes
Jul 20, 2023
damiannolan
approved these changes
Jul 20, 2023
| @@ -261,5 +261,8 @@ func call[T ContractResult](ctx sdk.Context, clientStore sdk.KVStore, cs *Client | |||
| if !output.Validate() { | |||
| return output, errorsmod.Wrapf(errors.New(output.Error()), "error occurred while calling contract with code ID %s", hex.EncodeToString(cs.CodeId)) | |||
| } | |||
| if len(out.Messages) > 0 { | |||
| return output, errorsmod.Wrapf(ErrWasmSubMessagesNotAllowed, "code hash (%s)", hex.EncodeToString(cs.CodeId)) | |||
There was a problem hiding this comment.
The var naming of out doesn't really feel intuitive to me, but we can rename it to whatever later, also maybe we could add something like this in a future improvement - handleContractResponse() ref
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Item 4.4 of Confio's report of 08-wasm audit.
This check prevents Wasm light client contracts to execute sub messages.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.