Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Version interface and casting functions from 03-connection #4110

Merged

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Jul 18, 2023

Description

  • Removes the exported.Version interface (legacy from GetVersions()) in favor of *Version type
  • Removes ExportedVersionsToProto & ProtoVersionsToExported casting functions (and removed from single .md file)
  • TODO Change log entry No need we will use the commit message to generate the changelog.

closes: #1690

Commit Message / Changelog Entry

imp: remove `Version` interface and casting functions from 03-connection

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@Reecepbcups Reecepbcups changed the title Remove legacy Version interface and casting functions Remove Version interface and casting functions from 03-connection Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #4110 (f5c7937) into main (4e1e594) will increase coverage by 0.01%.
The diff coverage is 86.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4110      +/-   ##
==========================================
+ Coverage   79.45%   79.47%   +0.01%     
==========================================
  Files         188      188              
  Lines       12990    12973      -17     
==========================================
- Hits        10321    10310      -11     
+ Misses       2240     2234       -6     
  Partials      429      429              
Files Changed Coverage Δ
modules/core/03-connection/types/codec.go 100.00% <ø> (ø)
modules/core/03-connection/types/connection.go 76.81% <0.00%> (ø)
modules/core/03-connection/keeper/handshake.go 88.58% <100.00%> (ø)
modules/core/03-connection/keeper/keeper.go 90.37% <100.00%> (ø)
modules/core/03-connection/types/version.go 96.38% <100.00%> (+5.85%) ⬆️
modules/core/keeper/msg_server.go 55.95% <100.00%> (ø)

@DimitrisJim DimitrisJim added the change: api breaking Issues or PRs that break Go API (need to be release in a new major version) label Jul 19, 2023
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thank you, @Reecepbcups!

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me so happy! Thank you @Reecepbcups, great cleanup

@crodriguezvega crodriguezvega merged commit 0bce6b5 into cosmos:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03-connection change: api breaking Issues or PRs that break Go API (need to be release in a new major version) core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Version interface from 03-connection interface types
6 participants