Amend CI testing to not build on arm, correctly cross compile on arm64. #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
chatton
as code owners
DimitrisJim
force-pushed
the
jim/ci-arm-build
branch
from
ef8f148 to
e33f913
Compare
DimitrisJim
commented
Jul 11, 2023
| @@ -36,7 +36,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go-arch: ['amd64', 'arm', 'arm64'] | |||
| go-arch: ['amd64', 'arm64'] | |||
There was a problem hiding this comment.
Reasoning: https://github.com/CosmWasm/wasmvm#builds-of-libwasmvm
Our system currently supports the following builds. In general we can only support targets that are supported by Wasmer's singlepass backend, which for example excludes all 32 bit systems.
DimitrisJim
commented
Jul 11, 2023
| - name: Build ibc-go | ||
| run: GOARCH=${{ matrix.go-arch }} LEDGER_ENABLED=false make build | ||
| run: GOARCH=${{ matrix.go-arch }} CGO_ENABLED=1 LEDGER_ENABLED=false make build |
There was a problem hiding this comment.
CGO_ENABLED is, by default, disabled if targeting an arch different than native.
DimitrisJim
changed the base branch from
carlos/3975-make-separate-gomod-for-08-wasm
to
feat/wasm-clients
DimitrisJim
changed the base branch from
feat/wasm-clients
to
carlos/3975-make-separate-gomod-for-08-wasm
|
this could also target main instead? Lmk what people think. |
charleenfei
approved these changes
Jul 12, 2023
crodriguezvega
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Great work figuring this out, @DimitrisJim and @charleenfei!
crodriguezvega
pushed a commit
that referenced
this pull request
Jul 13, 2023
* imp: add separate go.mod for 08-wasm * fix e2e build * remove import * lint * Amend CI testing to not build on arm, correctly cross compile on arm64. (#4065) * Use alpine for building simd in docker. Link statically. (#4066) --------- Co-authored-by: Charly <[email protected]> Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.