test: fix e2e and build issues (DO NOT REVIEW) #4031
Conversation
- Update footer links to add in CometBFT docs, and label Tendermint Core docs as archived (should probably still be linked to for a while still) - Changed youtube link to https://www.youtube.com/@interchain_io/featured. Cosmos youtube channel is no longer maintained - Removed link to interchain.berlin. Added link to interchain.io Co-authored-by: Carlos Rodriguez <[email protected]>
charleenfei
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
damiannolan,
chatton,
DimitrisJim and
srdtrk
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // InstantiateContractCosts costs when interacting with a wasm contract | ||
| func (g WasmGasRegister) InstantiateContractCosts(msgLen int) sdk.Gas { | ||
| if msgLen < 0 { | ||
| panic(sdkerrors.Wrap(ErrInvalid, "negative length")) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| func (g WasmGasRegister) ToWasmVMGas(source storetypes.Gas) uint64 { | ||
| x := source * g.c.GasMultiplier | ||
| if x < source { | ||
| panic(sdk.ErrorOutOfGas{Descriptor: "overflow"}) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| ctx.GasMeter().ConsumeGas(consumed, "wasm contract") | ||
| // throw OutOfGas error if we ran out (got exactly to zero due to better limit enforcing) | ||
| if ctx.GasMeter().IsOutOfGas() { | ||
| panic(sdk.ErrorOutOfGas{Descriptor: "Wasmer function execution"}) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| panic(err) | ||
| } | ||
|
|
||
| ctx := sdk.NewContext(nil, tmproto.Header{Height: 1, Time: time.Now()}, true, nil) // context with infinite gas meter |
Check warning
Code scanning / CodeQL
Calling the system time
| func (cs ClientState) UpdateState(ctx sdk.Context, cdc codec.BinaryCodec, clientStore sdk.KVStore, clientMsg exported.ClientMessage) []exported.Height { | ||
| header, ok := clientMsg.(*Header) | ||
| if !ok { | ||
| panic(fmt.Errorf("expected type %T, got %T", &Header{}, clientMsg)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| // newStoreAdapter constructor | ||
| func newStoreAdapter(s sdk.KVStore) *storeAdapter { | ||
| if s == nil { | ||
| panic("store must not be nil") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
|
|
||
| _, err := call[contractResult](ctx, clientStore, &cs, payload) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
|
|
||
| // safety checks before casting below | ||
| if height < 0 { | ||
| panic("Block height must never be negative") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| } | ||
| nsec := ctx.BlockTime().UnixNano() | ||
| if nsec < 0 { | ||
| panic("Block (unix) time must never be negative ") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
.github/workflows/test.yml
Outdated
| @@ -36,7 +36,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go-arch: ['amd64', 'arm', 'arm64'] | |||
| go-arch: ['amd64', 'arm'] | |||
There was a problem hiding this comment.
I think this matrix just needs to change unfortunately. Instead of cross compiling, compile using a runner that matches the arch. Didn't have time to check yesterday if mac-os runner actually has arm64 arch.
There was a problem hiding this comment.
No linux arm support apparently: actions/runner-images#5631
Similarly, mac-os doesn't seem to be using the new M1 arm64 chip: github/roadmap#528
There was a problem hiding this comment.
Update: can build on arm64, wasn't using cross compiler correctly. Can't on arm32 since wasmvm can't support it due to Wasmer not supporting it.
The previous does apply if we'd like to run the tests on arm64 via github runners tho.
charleenfei
changed the base branch from
feat/wasm-clients
to
carlos/3975-make-separate-gomod-for-08-wasm
charleenfei
changed the title
| RUN make build | ||
| # Grab the wasmvm library in order to copy it into the final image. | ||
| RUN cp $(ldd build/simd | grep "libwasmvm" | awk '{ print $3 }') libwasmvm.so |
There was a problem hiding this comment.
A question. Do we want to keep using multi-stage builds? This (and the copy in the next image on line 34) is required because libwasmvm is included in the wasmvm go lib (which we lose access to in the next stage).
Are the space savings worth the hassle?
There was a problem hiding this comment.
Note, they are worth it. Looking into #2442 though since that might offer benefits in reducing both size and linking issues like this.
rm unnecessary COPY Revert "rm unnecessary COPY" This reverts commit 5ed9782.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.