Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: reduce unnecessary var assignment in testing pkg #3961

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

colin-axner
Copy link
Contributor

Description

Most of the testing pkg was written years ago and still needs some code readability love. With a lot of small steps like this we can clean it up

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@colin-axner colin-axner added type: code hygiene Clean up code but without changing functionality or interfaces testing Testing package and unit/integration tests labels Jun 26, 2023
@colin-axner colin-axner enabled auto-merge (squash) June 26, 2023 14:21
@colin-axner colin-axner merged commit 6fcedca into main Jun 26, 2023
@colin-axner colin-axner deleted the colin/testing-nit branch June 26, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants