-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: workflow and linter improvements #3805
Merged
crodriguezvega
merged 117 commits into
feat/migrate-fully-to-docusaurus
from
serdar/issue#3543-docs-linters-and-workflows
Jul 9, 2023
Merged
Changes from all commits
Commits
Show all changes
117 commits
Select commit
Hold shift + click to select a range
097bd83
docs: added version 7.0.0 docs, need to check for bugs
srdtrk 5e3031c
docs: renamed the version to v7.0.0
srdtrk 8bc0f82
docs: added v6.1.0
srdtrk 669418a
docs: added v5.3.0
srdtrk d584076
docs: added v4.4.0
srdtrk 540e31b
docs: updated the base url redirect, and version banners
srdtrk 86f718a
docs: replaced 'Pre-requisites Readings' -> 'Pre-requisite readings'
srdtrk fc28566
docs: added missing ADRs to README.md
srdtrk 1c9c12a
docs: added versioning info to README.md
srdtrk 65e0569
docs: replaced '../../../../docs/architecture/adr-001-coin-source-tra…
srdtrk 876480d
docs: updated the url of the 7.0.0 (latest)
srdtrk 50faf02
docs: fixed all broken links
srdtrk 9ca28f3
docs: updated 'make build-docs' command to use docusaurus
srdtrk 44e9700
docs: Added a Links section to README.md
srdtrk cdf0190
docs: updated code blocks in 02-integration.md to use docusaurus feat…
srdtrk 5e42900
docs: removed all TODOs from README.md
srdtrk 4917a74
docs: updated the typical versioned docs tree in README.md
srdtrk 33ff84d
docs: made file naming section more precise
srdtrk f055fe2
docs: updated README.md
srdtrk 04b4416
docs: updated release-tracker.md
srdtrk bdba4a4
docs: removed search section from README.md
srdtrk 08dccc3
docs: updated release-management.md
srdtrk 971befb
docs: updated Makefile
srdtrk a2b4507
docs: fixed more broken links
srdtrk 7e91cfb
docs: updated workflows to only run when changes to main occur (not r…
srdtrk b995cd0
fix(ci): attempt to convert absolute urls to absolute filepaths in th…
srdtrk d38d752
fix(ci): added '@site/' to ignorePatterns instead
srdtrk a0490d4
imp(docs): removed wrong comment
srdtrk c55963f
fix(ci): fix markdown-link-check for docusaurus
srdtrk 06e5a81
docs: changed architecture links to absolute links
srdtrk d439532
fix(ci): replace only affects architect and event links now
srdtrk 626cf2d
docs: fix broken more links
srdtrk dac3281
imp(ci): ignore http links in markdown-link-check replace statements
srdtrk ebe56f5
imp(ci): markdown-link-check should only run on modified md files
srdtrk b288d12
fix(ci): attempt to fix markdown-link-check
srdtrk bbef134
fix(ci): only check modified files for markdown-link-check
srdtrk e9bb22e
revert(ci): reverted link-check.yml to initial state
srdtrk 3e18d92
imp(ci): set link check timeout to 16 mins
srdtrk 90a51a5
imp(ci/link-check): link-check should ignore versioned_docs now
srdtrk e1f797e
fix(ci/link-check): attempt to ignore files ending with '/'
srdtrk 0da2764
docs: fixed broken link
srdtrk fd65079
docs: fixed broken link in RELEASES.md
srdtrk e9f2a42
fix(ci/link-check): config works now
srdtrk b150de4
refactor(ci/link-check): combined two regexp patterns into one in lin…
srdtrk 080a4c3
fix(ci/link-check): config is good - attempt to fix the workflow
srdtrk f605fd9
fix(ci/link-check): config is good - attempt to fix the workflow
srdtrk 7f51688
fix(ci/link-check): added verbose mode
srdtrk b16ba80
revert(ci/link-check): reverted workflow to initial state (not config)
srdtrk 8d252bc
nit: broke a link to test ci
srdtrk dfa1fa1
revert(docs): fixed broken link
srdtrk 4490210
build(docs/deps): updated docusaurus to 2.4.1
srdtrk 7484dd3
docs: replaced intro titles
srdtrk 1ed2db1
docs: remove extra ')'
srdtrk bfa67f5
docs: wrapped some prerequisites in note
srdtrk 0422c52
docs: replaces '::: tip' with ':::tip'
srdtrk d3c72ad
docs: replace '::: warning' with ':::warning'
srdtrk 22c7d1c
docs: fix styling error
srdtrk ef29bcc
docs: readme updated
srdtrk 7387014
docs: removed all references to 'order:' frontmatter
srdtrk 7791861
docs: fixed list styling in transfer/state-transitions
srdtrk 4fcef9e
docs: removed unneeded quotation
srdtrk d9505f5
imp(docs): improved the markdownlint settings
srdtrk b20bc27
imp(docs): improved the markdownlint settings
srdtrk 3cdedd8
docs: ran markdownlint with the new config
srdtrk 50ca4af
docs: do not lint autogenerated CHANGELOG.md
srdtrk 75ee3bc
docs: removed 'bash' from the codeblock in the PR template
srdtrk 255724a
docs: added '.github' to .markdownlintignore
srdtrk 7ea4396
imp(docs): added more comments to markdownlint config
srdtrk 71feb9e
docs: fixed incorrect category linking
srdtrk e4365f9
docs: fixed indentation issue in fee middleware
srdtrk 5589b59
imp(docs): added two more rules to markdownlint
srdtrk 315e659
docs: ran 'make docs-lint'
srdtrk cfa1968
docs: made transfer the first app
srdtrk 36de913
docs: made transfer the first app in all versions
srdtrk 95308a1
imp(makefile/docs): added link-check to makefile
srdtrk 0326c58
docs: added back the spaces
srdtrk b561fb0
docs: fixed a lint violation
srdtrk d149bf5
merge: branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#35…
srdtrk 097f581
docs: contents of DOCS_GUIDELINES.md have been merged with README.md
srdtrk 8ff4909
docs: ran markdownlint-cli
srdtrk 4fcfa7a
docs: fixed a lot of linting errors
srdtrk 3730189
docs: fixed a more linting errors
srdtrk f8885a1
docs: fixed all linting errors
srdtrk 1354971
docs: corrected PR template's code box
srdtrk 3857db3
imp(docs): add a new workflow for linting changed markdown files
srdtrk 76ede3a
docs: fixed linter violation
srdtrk 95298e7
imp(docs): switch to using markdownlint-cli2
srdtrk 7f5885b
revert(ci/markdown-lint): original state
srdtrk 3b8aef3
imp(ci/markdown-lint): fix an error
srdtrk b3d3b00
imp(ci/markdown-lint): only runs on PRs which modify .md files
srdtrk 6a7516d
imp(ci/markdown-lint): only runs on PRs which modify .md files not in…
srdtrk a5ab880
docs: fixed broken link
srdtrk ca8d43a
imp(ci/link-check): this workflow only runs if a .md file has been mo…
srdtrk b7dc636
deps(docs): ran 'npm i --save @easyops-cn/docusaurus-search-local'
srdtrk a2b44c6
feat(docs): added local search bar
srdtrk 6a9bf5b
fix(docs): search bar highlight color is not buggy anymore
srdtrk 50d78f1
imp(docs): added term highlighting to search
srdtrk 2036883
merge: branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#35…
srdtrk c3d14da
merge: branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#35…
srdtrk dca0d68
merge: branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#35…
srdtrk a2c5e2f
fix: merge conflicts
srdtrk 98fb326
docs: ran linter
srdtrk d5b74e0
refactor: removed markdownlint changes in this PR
srdtrk eb31283
refactor: removed markdownlint changes in this PR
srdtrk b401b31
refactor: removed linkcheck changes in this PR
srdtrk 5a23809
revert: changes in PR template
srdtrk f6cdcdb
revert: added swagger-docs thing back
srdtrk a900499
revert: "revert: added swagger-docs thing back"
srdtrk c98c891
revert: "revert: changes in PR template"
srdtrk 5866654
revert: "refactor: removed linkcheck changes in this PR"
srdtrk ece4786
revert: "refactor: removed markdownlint changes in this PR"
srdtrk 9049f3d
revert: "refactor: removed markdownlint changes in this PR"
srdtrk d0b8ac4
Merge branch 'main' into serdar/issue#3543-docs-linters-and-workflows
crodriguezvega d4c1ea8
Merge branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#354…
crodriguezvega 7b316a4
add extra path to ignore
crodriguezvega 13d9f0d
docs linting
crodriguezvega fbecd9b
Update docs/docs/01-ibc/09-roadmap.md
crodriguezvega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ closes: #XXXX | |
|
||
### Commit Message / Changelog Entry | ||
|
||
```bash | ||
```text | ||
type: commit message | ||
``` | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,14 @@ | ||
name: Check Markdown links | ||
on: pull_request | ||
on: | ||
pull_request: | ||
paths: | ||
- "**.md" | ||
- "!.github/**" | ||
jobs: | ||
markdown-link-check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: gaurav-nelson/github-action-markdown-link-check@v1 | ||
with: | ||
config-file: '.github/workflows/link-check-config.json' | ||
- uses: actions/checkout@v3 | ||
- uses: gaurav-nelson/github-action-markdown-link-check@v1 | ||
with: | ||
config-file: '.github/workflows/link-check-config.json' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: Markdown Lint | ||
on: | ||
pull_request: | ||
paths: | ||
- "**.md" | ||
- "!.github/**" | ||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
- uses: tj-actions/changed-files@v35 | ||
id: changed-files | ||
with: | ||
files: "**/*.md" | ||
separator: "," | ||
- uses: DavidAnson/markdownlint-cli2-action@v10 | ||
if: steps.changed-files.outputs.any_changed == 'true' | ||
with: | ||
globs: ${{ steps.changed-files.outputs.all_changed_files }} | ||
separator: "," |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// This file is used by markdownlint-cli2 to configure the linting process | ||
// in conjunction with .markdownlint.jsonc. | ||
{ | ||
"ignores": [ | ||
"docs/node_modules/**", | ||
".github", | ||
"CHANGELOG.md", | ||
"vendor/**", | ||
"e2e/vendor/**", | ||
"modules/capability/vendor/**" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,17 @@ | ||
{ | ||
"default": true, | ||
"MD003": { "style": "atx" }, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md003---heading-style | ||
"MD004": { "style": "dash" }, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md004---unordered-list-style | ||
"MD007": { "indent": 4 }, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md007---unordered-list-indentation | ||
"MD009": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md009---trailing-spaces | ||
"MD010": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md010---hard-tabs | ||
"MD013": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md013---line-length | ||
"MD024": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md024---multiple-headings-with-the-same-content | ||
"MD025": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md025---multiple-top-level-headings-in-the-same-document | ||
"MD029": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix | ||
"MD033": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md033---inline-html | ||
"MD036": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md036---emphasis-used-instead-of-a-heading | ||
"MD041": false // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md041---first-line-in-a-file-should-be-a-top-level-heading | ||
"MD041": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md041---first-line-in-a-file-should-be-a-top-level-heading | ||
"MD049": { "style": "asterisk" }, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md049---emphasis-style-should-be-consistent | ||
"MD050": { "style": "asterisk" } // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md050---strong-style-should-be-consistent | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -138,16 +138,6 @@ go.sum: go.mod | |
### Documentation ### | ||
############################################################################### | ||
|
||
update-swagger-docs: statik | ||
$(BINDIR)/statik -src=docs/client/swagger-ui -dest=docs/client -f -m | ||
@if [ -n "$(git status --porcelain)" ]; then \ | ||
echo "\033[91mSwagger docs are out of sync!!!\033[0m";\ | ||
exit 1;\ | ||
else \ | ||
echo "\033[92mSwagger docs are in sync\033[0m";\ | ||
fi | ||
.PHONY: update-swagger-docs | ||
|
||
godocs: | ||
@echo "--> Wait a few seconds and visit http://localhost:6060/pkg/github.com/cosmos/cosmos-sdk/types" | ||
godoc -http=:6060 | ||
|
@@ -292,10 +282,13 @@ format: | |
.PHONY: format | ||
|
||
docs-lint: | ||
markdownlint . --fix | ||
markdownlint-cli2 "**.md" | ||
|
||
docs-lint-fix: | ||
markdownlint-cli2-fix "**.md" | ||
|
||
docs-lint-changed: | ||
./scripts/linting/lint-changed-md-files.sh | ||
docs-link-check: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be able to run this we need to have |
||
find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check --config ./.github/workflows/link-check-config.json | ||
|
||
.PHONY: lint lint-fix lint-fix-changed docs-lint docs-lint-changed | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used?