Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: workflow and linter improvements #3805

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
117 commits
Select commit Hold shift + click to select a range
097bd83
docs: added version 7.0.0 docs, need to check for bugs
srdtrk May 6, 2023
5e3031c
docs: renamed the version to v7.0.0
srdtrk May 6, 2023
8bc0f82
docs: added v6.1.0
srdtrk May 6, 2023
669418a
docs: added v5.3.0
srdtrk May 6, 2023
d584076
docs: added v4.4.0
srdtrk May 7, 2023
540e31b
docs: updated the base url redirect, and version banners
srdtrk May 7, 2023
86f718a
docs: replaced 'Pre-requisites Readings' -> 'Pre-requisite readings'
srdtrk May 7, 2023
fc28566
docs: added missing ADRs to README.md
srdtrk May 7, 2023
1c9c12a
docs: added versioning info to README.md
srdtrk May 7, 2023
65e0569
docs: replaced '../../../../docs/architecture/adr-001-coin-source-tra…
srdtrk May 7, 2023
876480d
docs: updated the url of the 7.0.0 (latest)
srdtrk May 7, 2023
50faf02
docs: fixed all broken links
srdtrk May 7, 2023
9ca28f3
docs: updated 'make build-docs' command to use docusaurus
srdtrk May 7, 2023
44e9700
docs: Added a Links section to README.md
srdtrk May 7, 2023
cdf0190
docs: updated code blocks in 02-integration.md to use docusaurus feat…
srdtrk May 7, 2023
5e42900
docs: removed all TODOs from README.md
srdtrk May 7, 2023
4917a74
docs: updated the typical versioned docs tree in README.md
srdtrk May 7, 2023
33ff84d
docs: made file naming section more precise
srdtrk May 8, 2023
f055fe2
docs: updated README.md
srdtrk May 8, 2023
04b4416
docs: updated release-tracker.md
srdtrk May 8, 2023
bdba4a4
docs: removed search section from README.md
srdtrk May 8, 2023
08dccc3
docs: updated release-management.md
srdtrk May 8, 2023
971befb
docs: updated Makefile
srdtrk May 8, 2023
a2b4507
docs: fixed more broken links
srdtrk May 8, 2023
7e91cfb
docs: updated workflows to only run when changes to main occur (not r…
srdtrk May 8, 2023
b995cd0
fix(ci): attempt to convert absolute urls to absolute filepaths in th…
srdtrk May 17, 2023
d38d752
fix(ci): added '@site/' to ignorePatterns instead
srdtrk May 17, 2023
a0490d4
imp(docs): removed wrong comment
srdtrk May 17, 2023
c55963f
fix(ci): fix markdown-link-check for docusaurus
srdtrk May 17, 2023
06e5a81
docs: changed architecture links to absolute links
srdtrk May 18, 2023
d439532
fix(ci): replace only affects architect and event links now
srdtrk May 18, 2023
626cf2d
docs: fix broken more links
srdtrk May 18, 2023
dac3281
imp(ci): ignore http links in markdown-link-check replace statements
srdtrk May 18, 2023
ebe56f5
imp(ci): markdown-link-check should only run on modified md files
srdtrk May 18, 2023
b288d12
fix(ci): attempt to fix markdown-link-check
srdtrk May 18, 2023
bbef134
fix(ci): only check modified files for markdown-link-check
srdtrk May 18, 2023
e9bb22e
revert(ci): reverted link-check.yml to initial state
srdtrk May 18, 2023
3e18d92
imp(ci): set link check timeout to 16 mins
srdtrk May 18, 2023
90a51a5
imp(ci/link-check): link-check should ignore versioned_docs now
srdtrk May 18, 2023
e1f797e
fix(ci/link-check): attempt to ignore files ending with '/'
srdtrk May 18, 2023
0da2764
docs: fixed broken link
srdtrk May 18, 2023
fd65079
docs: fixed broken link in RELEASES.md
srdtrk May 18, 2023
e9f2a42
fix(ci/link-check): config works now
srdtrk May 18, 2023
b150de4
refactor(ci/link-check): combined two regexp patterns into one in lin…
srdtrk May 18, 2023
080a4c3
fix(ci/link-check): config is good - attempt to fix the workflow
srdtrk May 18, 2023
f605fd9
fix(ci/link-check): config is good - attempt to fix the workflow
srdtrk May 18, 2023
7f51688
fix(ci/link-check): added verbose mode
srdtrk May 18, 2023
b16ba80
revert(ci/link-check): reverted workflow to initial state (not config)
srdtrk May 18, 2023
8d252bc
nit: broke a link to test ci
srdtrk May 18, 2023
dfa1fa1
revert(docs): fixed broken link
srdtrk May 18, 2023
4490210
build(docs/deps): updated docusaurus to 2.4.1
srdtrk May 19, 2023
7484dd3
docs: replaced intro titles
srdtrk May 19, 2023
1ed2db1
docs: remove extra ')'
srdtrk May 19, 2023
bfa67f5
docs: wrapped some prerequisites in note
srdtrk May 19, 2023
0422c52
docs: replaces '::: tip' with ':::tip'
srdtrk May 19, 2023
d3c72ad
docs: replace '::: warning' with ':::warning'
srdtrk May 19, 2023
22c7d1c
docs: fix styling error
srdtrk May 19, 2023
ef29bcc
docs: readme updated
srdtrk May 19, 2023
7387014
docs: removed all references to 'order:' frontmatter
srdtrk May 19, 2023
7791861
docs: fixed list styling in transfer/state-transitions
srdtrk May 19, 2023
4fcef9e
docs: removed unneeded quotation
srdtrk May 19, 2023
d9505f5
imp(docs): improved the markdownlint settings
srdtrk May 19, 2023
b20bc27
imp(docs): improved the markdownlint settings
srdtrk May 19, 2023
3cdedd8
docs: ran markdownlint with the new config
srdtrk May 19, 2023
50ca4af
docs: do not lint autogenerated CHANGELOG.md
srdtrk May 19, 2023
75ee3bc
docs: removed 'bash' from the codeblock in the PR template
srdtrk May 19, 2023
255724a
docs: added '.github' to .markdownlintignore
srdtrk May 19, 2023
7ea4396
imp(docs): added more comments to markdownlint config
srdtrk May 19, 2023
71feb9e
docs: fixed incorrect category linking
srdtrk May 19, 2023
e4365f9
docs: fixed indentation issue in fee middleware
srdtrk May 19, 2023
5589b59
imp(docs): added two more rules to markdownlint
srdtrk May 19, 2023
315e659
docs: ran 'make docs-lint'
srdtrk May 19, 2023
cfa1968
docs: made transfer the first app
srdtrk May 19, 2023
36de913
docs: made transfer the first app in all versions
srdtrk May 19, 2023
95308a1
imp(makefile/docs): added link-check to makefile
srdtrk May 19, 2023
0326c58
docs: added back the spaces
srdtrk May 19, 2023
b561fb0
docs: fixed a lint violation
srdtrk May 19, 2023
d149bf5
merge: branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#35…
srdtrk May 19, 2023
097f581
docs: contents of DOCS_GUIDELINES.md have been merged with README.md
srdtrk May 19, 2023
8ff4909
docs: ran markdownlint-cli
srdtrk May 19, 2023
4fcfa7a
docs: fixed a lot of linting errors
srdtrk May 19, 2023
3730189
docs: fixed a more linting errors
srdtrk May 19, 2023
f8885a1
docs: fixed all linting errors
srdtrk May 19, 2023
1354971
docs: corrected PR template's code box
srdtrk May 19, 2023
3857db3
imp(docs): add a new workflow for linting changed markdown files
srdtrk May 19, 2023
76ede3a
docs: fixed linter violation
srdtrk May 19, 2023
95298e7
imp(docs): switch to using markdownlint-cli2
srdtrk May 19, 2023
7f5885b
revert(ci/markdown-lint): original state
srdtrk May 19, 2023
3b8aef3
imp(ci/markdown-lint): fix an error
srdtrk May 19, 2023
b3d3b00
imp(ci/markdown-lint): only runs on PRs which modify .md files
srdtrk May 19, 2023
6a7516d
imp(ci/markdown-lint): only runs on PRs which modify .md files not in…
srdtrk May 19, 2023
a5ab880
docs: fixed broken link
srdtrk May 19, 2023
ca8d43a
imp(ci/link-check): this workflow only runs if a .md file has been mo…
srdtrk May 19, 2023
b7dc636
deps(docs): ran 'npm i --save @easyops-cn/docusaurus-search-local'
srdtrk May 21, 2023
a2b44c6
feat(docs): added local search bar
srdtrk May 21, 2023
6a9bf5b
fix(docs): search bar highlight color is not buggy anymore
srdtrk May 21, 2023
50d78f1
imp(docs): added term highlighting to search
srdtrk May 21, 2023
2036883
merge: branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#35…
srdtrk May 29, 2023
c3d14da
merge: branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#35…
srdtrk May 29, 2023
dca0d68
merge: branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#35…
srdtrk Jun 9, 2023
a2c5e2f
fix: merge conflicts
srdtrk Jun 9, 2023
98fb326
docs: ran linter
srdtrk Jun 9, 2023
d5b74e0
refactor: removed markdownlint changes in this PR
srdtrk Jun 9, 2023
eb31283
refactor: removed markdownlint changes in this PR
srdtrk Jun 9, 2023
b401b31
refactor: removed linkcheck changes in this PR
srdtrk Jun 9, 2023
5a23809
revert: changes in PR template
srdtrk Jun 9, 2023
f6cdcdb
revert: added swagger-docs thing back
srdtrk Jun 9, 2023
a900499
revert: "revert: added swagger-docs thing back"
srdtrk Jun 9, 2023
c98c891
revert: "revert: changes in PR template"
srdtrk Jun 9, 2023
5866654
revert: "refactor: removed linkcheck changes in this PR"
srdtrk Jun 9, 2023
ece4786
revert: "refactor: removed markdownlint changes in this PR"
srdtrk Jun 9, 2023
9049f3d
revert: "refactor: removed markdownlint changes in this PR"
srdtrk Jun 9, 2023
d0b8ac4
Merge branch 'main' into serdar/issue#3543-docs-linters-and-workflows
crodriguezvega Jul 4, 2023
d4c1ea8
Merge branch 'feat/migrate-fully-to-docusaurus' into serdar/issue#354…
crodriguezvega Jul 4, 2023
7b316a4
add extra path to ignore
crodriguezvega Jul 4, 2023
13d9f0d
docs linting
crodriguezvega Jul 4, 2023
fbecd9b
Update docs/docs/01-ibc/09-roadmap.md
crodriguezvega Jul 6, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ closes: #XXXX

### Commit Message / Changelog Entry

```bash
```text
type: commit message
```

Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/link-check.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
name: Check Markdown links
on: pull_request
on:
pull_request:
paths:
- "**.md"
- "!.github/**"
jobs:
markdown-link-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
config-file: '.github/workflows/link-check-config.json'
- uses: actions/checkout@v3
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
config-file: '.github/workflows/link-check-config.json'
23 changes: 23 additions & 0 deletions .github/workflows/markdown-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Markdown Lint
on:
pull_request:
paths:
- "**.md"
- "!.github/**"
jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: tj-actions/changed-files@v35
id: changed-files
with:
files: "**/*.md"
separator: ","
- uses: DavidAnson/markdownlint-cli2-action@v10
if: steps.changed-files.outputs.any_changed == 'true'
with:
globs: ${{ steps.changed-files.outputs.all_changed_files }}
separator: ","
12 changes: 12 additions & 0 deletions .markdownlint-cli2.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// This file is used by markdownlint-cli2 to configure the linting process
// in conjunction with .markdownlint.jsonc.
{
"ignores": [
"docs/node_modules/**",
".github",
"CHANGELOG.md",
"vendor/**",
"e2e/vendor/**",
"modules/capability/vendor/**"
]
}
9 changes: 8 additions & 1 deletion .markdownlint.jsonc
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
{
"default": true,
"MD003": { "style": "atx" }, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md003---heading-style
"MD004": { "style": "dash" }, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md004---unordered-list-style
"MD007": { "indent": 4 }, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md007---unordered-list-indentation
"MD009": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md009---trailing-spaces
"MD010": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md010---hard-tabs
"MD013": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md013---line-length
"MD024": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md024---multiple-headings-with-the-same-content
"MD025": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md025---multiple-top-level-headings-in-the-same-document
"MD029": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix
"MD033": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md033---inline-html
"MD036": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md036---emphasis-used-instead-of-a-heading
"MD041": false // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md041---first-line-in-a-file-should-be-a-top-level-heading
"MD041": false, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md041---first-line-in-a-file-should-be-a-top-level-heading
"MD049": { "style": "asterisk" }, // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md049---emphasis-style-should-be-consistent
"MD050": { "style": "asterisk" } // https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md050---strong-style-should-be-consistent
}
3 changes: 0 additions & 3 deletions .markdownlintignore

This file was deleted.

19 changes: 6 additions & 13 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -138,16 +138,6 @@ go.sum: go.mod
### Documentation ###
###############################################################################

update-swagger-docs: statik
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used?

$(BINDIR)/statik -src=docs/client/swagger-ui -dest=docs/client -f -m
@if [ -n "$(git status --porcelain)" ]; then \
echo "\033[91mSwagger docs are out of sync!!!\033[0m";\
exit 1;\
else \
echo "\033[92mSwagger docs are in sync\033[0m";\
fi
.PHONY: update-swagger-docs

godocs:
@echo "--> Wait a few seconds and visit http://localhost:6060/pkg/github.com/cosmos/cosmos-sdk/types"
godoc -http=:6060
Expand Down Expand Up @@ -292,10 +282,13 @@ format:
.PHONY: format

docs-lint:
markdownlint . --fix
markdownlint-cli2 "**.md"

docs-lint-fix:
markdownlint-cli2-fix "**.md"

docs-lint-changed:
./scripts/linting/lint-changed-md-files.sh
docs-link-check:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to run this we need to have markdown-link-check installed, right?

find . -name \*.md -print0 | xargs -0 -n1 markdown-link-check --config ./.github/workflows/link-check-config.json

.PHONY: lint lint-fix lint-fix-changed docs-lint docs-lint-changed

Expand Down
2 changes: 1 addition & 1 deletion docs/docs/01-ibc/09-roadmap.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ slug: /roadmap/roadmap

# Roadmap ibc-go

_Lastest update: June 23th, 2023_
*Latest update: June 23th, 2023*

This document endeavours to inform the wider IBC community about plans and priorities for work on ibc-go by the team at Interchain GmbH. It is intended to broadly inform all users of ibc-go, including developers and operators of IBC, relayer, chain and wallet applications.

Expand Down
5 changes: 3 additions & 2 deletions docs/docs/05-migrations/10-v7-to-v8.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,9 @@ TODO: <https://github.com/cosmos/ibc-go/pull/3505> (extra parameter added to tra
## IBC Apps

TODO:
- https://github.com/cosmos/ibc-go/pull/3303
- https://github.com/cosmos/ibc-go/pull/3967

- <https://github.com/cosmos/ibc-go/pull/3303>
- <https://github.com/cosmos/ibc-go/pull/3967>

## Relayers

Expand Down
13 changes: 0 additions & 13 deletions scripts/linting/lint-changed-md-files.sh

This file was deleted.