Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove simd testnet cmd and cosmossdk.io/simapp dependency #3554

Merged
merged 1 commit into from
May 4, 2023

Conversation

damiannolan
Copy link
Member

Description

  • Removes the simd testnet cmd and the cosmossdk.io/simapp dependency

closes: #3545

Commit Message / Changelog Entry

chore: remove simd testnet cmd and cosmossdk.io/simapp dependency

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan damiannolan marked this pull request as ready for review May 4, 2023 07:44
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@damiannolan damiannolan merged commit 9c1a81d into main May 4, 2023
@damiannolan damiannolan deleted the damian/3545-remove-simapp-dep branch May 4, 2023 08:26
mergify bot pushed a commit that referenced this pull request Jun 22, 2023
crodriguezvega pushed a commit that referenced this pull request Jun 22, 2023
@faddat faddat mentioned this pull request Jun 23, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the dependency on cosmossdk.io/simapp
4 participants