Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump ics23 v0.10.0 (backport #3457) #3471

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 18, 2023

This is an automatic backport of pull request #3457 done by Mergify.
Cherry-pick of 0a15a03 has failed:

On branch mergify/bp/release/v4.4.x/pr-3457
Your branch is up to date with 'origin/release/v4.4.x'.

You are currently cherry-picking commit 0a15a03d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   e2e/go.mod
	deleted by us:   e2e/go.sum
	both modified:   go.mod
	both modified:   go.sum
	deleted by us:   modules/capability/go.mod
	deleted by us:   modules/capability/go.sum

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 0a15a03)

# Conflicts:
#	e2e/go.mod
#	e2e/go.sum
#	go.mod
#	go.sum
#	modules/capability/go.mod
#	modules/capability/go.sum
@chatton
Copy link
Contributor

chatton commented Apr 19, 2023

why is a go.sum entry changing without a go.mod entry changing?

cc @crodriguezvega

@crodriguezvega
Copy link
Contributor

why is a go.sum entry changing without a go.mod entry changing?

cc @crodriguezvega

I push something by mistake, but this is still work in progress. I am having some issues to backport ics23 to the pre v7 branches...

@faddat
Copy link
Contributor

faddat commented Apr 20, 2023

@crodriguezvega -- same thing here. I'll provide a PR for your reference to interchain security where I am having the same problem:

cosmos/interchain-security#864

Please note that we are also interested in getting some code landed in ibc-go to support interchain security. I am not sure how large the changes are, and I will make a draft PR for review shortly containing work by Son and Vuong.

Thanks!

@crodriguezvega
Copy link
Contributor

We will close this backport since it turns out that ics23 v0.10.0 cannot be back ported to pre-v7 release lines.

From @colin-axner's investigation: This is because in v7 the SDK migrated from a fork for gogoproto to the repo cosmos/gogoproto. ics23 is registering on the migrated repo while v4-v6 use the fork.

@crodriguezvega crodriguezvega deleted the mergify/bp/release/v4.4.x/pr-3457 branch April 24, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants