chore: Add tests for acknowledgement.Acknowledgement() #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
webmaster128
commented
Apr 11, 2023
| suite.NotPanics(func() { | ||
| bz := tc.ack.Acknowledgement() | ||
| suite.Require().NotNil(bz) | ||
| }) |
There was a problem hiding this comment.
I moved the check up to the ValidateBasic success case because I don't want to make any assumptions how invalid instances are marchalled. Probybly they should never be marshalled.
damiannolan
approved these changes
Apr 12, 2023
charleenfei
approved these changes
Apr 12, 2023
colin-axner
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Thanks @webmaster128! Appreciate the time you took to better our testing :) ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates unit testing for the binary serialization of
acknowledgement.Acknowledgement()to ensure the serialization is complient with the standard and other implementations.Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.