Add interchain account address to packet 1 acknowledgement #333
Conversation
add interchain account address to acknowledgement for packet 1 add placeholder code for onAck parsing of ack start writing tests
colin-axner
changed the title
| if packet.Sequence == 1 && ack.Success() { | ||
| // pass interchain account address into base applications | ||
| // connected to the middleware | ||
| } |
There was a problem hiding this comment.
this information shouldn't be set in state since we could have domain conflicts (this module acts as a host and controller in some cases). It's usefulness is passing this information to helper modules, but even so we will likely end up using the version to convey this information
|
Sweet, I finally got the codeowner file to work right |
Nice!! |
There was a problem hiding this comment.
I'm wondering if we should even go down this path at the moment.
I think it's not going to be a large amount of work to get the interchain-account address set on the controller side via the version string. It's basically just the query endpoint on the ibc-go side and then a minor change on the hermes side (you had some ideas for a more complete approach on the hermes side, but a short term solution is to just replace a hardcoded value with a call to the query endpoint on our side).
I think we could potentially get this done pretty quickly, and it'll give us the nicest UX and feature completeness within interchain-accounts.
Yea I agree. I'd prefer to just move forward with the version solution. Shall we close this pr? |
Yep, yep. I'll update the issue as well. Thank you for starting this 🤝 |
Description
closes: #318
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes