Make HasCapability private #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expertdicer
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan,
chatton and
tmsdkeys
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3303 +/- ##
==========================================
- Coverage 78.59% 78.54% -0.06%
==========================================
Files 181 181
Lines 12546 12581 +35
==========================================
+ Hits 9861 9882 +21
- Misses 2252 2265 +13
- Partials 433 434 +1
|
modules/apps/27-interchain-accounts/controller/keeper/export_test.go
Outdated
Show resolved
Hide resolved
You're welcome! |
crodriguezvega
suggested changes
Apr 3, 2023
There was a problem hiding this comment.
Thank you, @expertdicer. I think if we remove those testing functions and rebase with main, the PR should be ready to be merged. :)
crodriguezvega
suggested changes
Apr 3, 2023
There was a problem hiding this comment.
Thank you, @expertdicer. I think if we remove those testing functions and rebase with main, the PR should be ready to be merged. :)
expertdicer
force-pushed
the
nguyen/private-capability
branch
from
95da490 to
6f429f5
Compare
There was a problem hiding this comment.
We're almost there, @expertdicer! Just need to make the linter happy now. :)
modules/apps/27-interchain-accounts/controller/keeper/genesis.go
Outdated
Show resolved
Hide resolved
colin-axner
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Thank you @expertdicer! Appreciate the followups and your patience 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3289
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.