Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding go.work and go.work.sum to gitignore #3109

Merged
merged 5 commits into from
Feb 13, 2023

Conversation

damiannolan
Copy link
Member

Description

I have recently started using a go.work file locally. It fixes an issue for me when using two go mods inside a single vscode workspace. Previously, opening any e2e files would show errors in vscode if the workspace is opened from the root of ibc-go. Adding a simple go.work file solves this.

There was some discussion about this in #1784 but we chose to not add it.
I propose that we follow what the sdk has done and add to .gitignore and provide a sample go.work file that people can chose to use locally if desired.

closes: #XXXX

Commit Message / Changelog Entry

chore: adding go.work to gitignore and providing example work file

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @damiannolan!

@crodriguezvega crodriguezvega merged commit 55300ab into main Feb 13, 2023
@crodriguezvega crodriguezvega deleted the damian/update-ignorefile branch February 13, 2023 20:42
stackman27 pushed a commit to stackman27/ibc-go that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants