docs: adding migration doc info for sdk v0.47 #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
chatton and
tmsdkeys
as code owners
julienrbrt
reviewed
Feb 6, 2023
docs/migrations/v6-to-v7.md
Outdated
| // ProposalContents doesn't return any content functions for governance proposals. | ||
| - func (AppModule) ProposalContents(_ module.SimulationState) []simtypes.WeightedProposalContent { | ||
| + func (AppModule) ProposalContents(_ module.SimulationState) []simtypes.WeightedProposalMsg { |
There was a problem hiding this comment.
Actually, the return value from ProposalContents has not been updated. We've created an additional method that can define a proposal msg for simulation:
9 tasks
colin-axner
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Thanks @damiannolan! I addressed @julienrbrt's comments. LGTM now
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
* adding migration doc info for sdk v0.47 * code alignment * title formatting * chore: preemptively apply changes from #3149 * chore: apply changes from #3150 * chore: formatting * chore: combine proposal contents removal into existing section --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Colin Axnér <[email protected]> (cherry picked from commit f034e6b) # Conflicts: # docs/migrations/v6-to-v7.md
damiannolan
added a commit
that referenced
this pull request
Feb 15, 2023
Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Colin Axnér <[email protected]>
stackman27
pushed a commit
to stackman27/ibc-go
that referenced
this pull request
Mar 13, 2023
* adding migration doc info for sdk v0.47 * code alignment * title formatting * chore: preemptively apply changes from cosmos#3149 * chore: apply changes from cosmos#3150 * chore: formatting * chore: combine proposal contents removal into existing section --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Colin Axnér <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have gone through the #2672 and #2095 PRs and so far came up with these changes to be included.
I have disregarded changes to test code and simapp as I didn't see most of the changes as relevant. Perhaps some changes to simapp should be included, but we can add to this PR if necessary.
closes: #2918
Commit Message / Changelog Entry
docs: adding migration doc info for sdk v0.47see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.