Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ErrDuplicateEntry to ErrInvalidAuthorization & change error formatting #2988

Merged
merged 8 commits into from
Jan 9, 2023
Merged

Change ErrDuplicateEntry to ErrInvalidAuthorization & change error formatting #2988

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
47a166c
chore: fixing unit tests and making isAllowedAddress private
chatton Jan 9, 2023
ea645de
chore: ran formatter
chatton Jan 9, 2023
102f31a
chore: changing error type
chatton Jan 9, 2023
14d771d
Merge branch 'feat/authz-ics20' into cian/update-errors
chatton Jan 9, 2023
b793e1a
Merge branch 'feat/authz-ics20' into cian/update-errors
chatton Jan 9, 2023
55bdcfd
Merge branch 'feat/authz-ics20' into cian/update-errors
chatton Jan 9, 2023
4ea5575
chore: restructured errors to use correct format
chatton Jan 9, 2023
e68adb9
chore: fix formatting
chatton Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/apps/transfer/types/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ var (
ErrSendDisabled = sdkerrors.Register(ModuleName, 7, "fungible token transfers from this chain are disabled")
ErrReceiveDisabled = sdkerrors.Register(ModuleName, 8, "fungible token transfers to this chain are disabled")
ErrMaxTransferChannels = sdkerrors.Register(ModuleName, 9, "max transfer channels")
ErrDuplicateEntry = sdkerrors.Register(ModuleName, 10, "duplicated entry")
ErrInvalidAuthorization = sdkerrors.Register(ModuleName, 10, "invalid transfer authorization")
)
2 changes: 1 addition & 1 deletion modules/apps/transfer/types/transfer_authz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func (a TransferAuthorization) ValidateBasic() error {
found := make(map[string]bool, 0)
for i := 0; i < len(allocation.AllowedAddresses); i++ {
if found[allocation.AllowedAddresses[i]] {
return ErrDuplicateEntry
return sdkerrors.Wrapf(ErrInvalidAuthorization, "duplicate entry in allow list %s")
}
found[allocation.AllowedAddresses[i]] = true
}
Expand Down