-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: limit receive addresses to 2kb #2983
Merged
crodriguezvega
merged 19 commits into
cosmos:carlos/4859-unbounded-field-lengths
from
notional-labs:address-length-limit
Oct 30, 2023
Merged
fix: limit receive addresses to 2kb #2983
crodriguezvega
merged 19 commits into
cosmos:carlos/4859-unbounded-field-lengths
from
notional-labs:address-length-limit
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
changed the title
receive Address length limit
fix: limit receive addresses to 2kb
Jan 6, 2023
6 tasks
crodriguezvega
changed the base branch from
main
to
carlos/4859-unbounded-field-lengths
October 15, 2023 22:04
3 tasks
faddat
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
October 19, 2023 16:35
faddat
requested review from
crodriguezvega,
charleenfei,
chatton and
DimitrisJim
as code owners
October 19, 2023 16:35
DimitrisJim
approved these changes
Oct 30, 2023
damiannolan
approved these changes
Oct 30, 2023
crodriguezvega
merged commit Oct 30, 2023
075f65f
into
cosmos:carlos/4859-unbounded-field-lengths
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds limitations to the length of ibc receive addresses.
A 2kb size was chosen to preserve the flexible use of the receive address field, where it's just a string and can be interpreted by various modules to trigger other functionality.
TODO:
Commit Message / Changelog Entry
fix: [#2983](https://github.com/cosmos/ibc-go/pull/2983) Limits the receive address length to 2kb
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.