Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update consensus state docs #2937
docs: update consensus state docs #2937
Changes from 2 commits
3f62d52
ceba7d6
f2e99c4
8bbdae8
00cf759
2c42384
027b25e
7bd9224
3e1562b
d5383ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion, but I think I would explain this line
a
ClientMessage
referencing the TendermintClientType
will then triggera bit differently:
UpdateClient
retrieves the client state by client ID (available inMsgUpdateClient
). This client state implements theClientState
interface for a specific client type (e.g. Tendermint). The functions called on the client state instance inUpdateClient
will be the specific implementations ofVerifyClientMessage
,CheckForMisbehaviour
,UpdateStateOnMisbehaviour
andUpdateState
functions of theClientState
interface for that particular client type.Just an idea!