Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk 47 #2416

Closed
wants to merge 3 commits into from
Closed

sdk 47 #2416

wants to merge 3 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 27, 2022

Description

This PR begins integration work for cosmos-sdk 47 and will be developed in tandem with

As before, this branch is meant for ecosystem devs to be able to reference


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner
Copy link
Contributor

colin-axner commented Sep 28, 2022

Thanks @faddat for starting this work. Agreed that it'd be nice to make bumping a major version of the SDK as smooth as possible.

I'm going to mark this pr as a draft for now as it isn't ready for merging.

In my mind, I think it makes sense to have a feature branch which we merge all changes into after small scoped reviews. Similar to what we tried to do last time. We can use this as the feature branch, but it might be nicer to have a branch that is created on ibc-go so we have merge rights to that branch

I think it makes sense to do each change incrementally even if the tests don't pass immediately. I think getting all tests to pass is more important at the end

If you agree, maybe we can create a branch on ibc-go that will act as the branch to bump to SDK v0.47 and then you can open a draft pr for that branch? Then any change should be a pr opened against that branch (and these changes can be made without all tests passing so we can have smaller prs to review). We should create a tracking issue with all the changes that need to be made as well

During this process, maybe we can document what works so we can standardize this workflow for future usage

@faddat
Copy link
Contributor Author

faddat commented Sep 28, 2022

hey :D!

I think that's a really great idea, that way we don't end up messing about with main too much. This is surely a draft PR -- I figure there'll likely be a number of breaking changes.

@crodriguezvega
Copy link
Contributor

hey @faddat, thanks very much for helping us with another SDK upgrade. :)

As per @colin-axner's suggestion here the feature branch we can use.

@faddat faddat changed the base branch from main to upgrade-sdk-0.47 October 9, 2022 03:58
@faddat faddat closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants