Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Failed token transfer receiver address is not valid #1996

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Aug 12, 2022

Description

closes: #1964


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

colin-axner and others added 30 commits August 10, 2022 16:57
…lows' of https://github.com/cosmos/ibc-go into cian/issue#1980-update-our-e2e-ci-to-use-reusable-workflows
Comment on lines +7 to +8
export CHAIN_A_SIMD_TAG="${CHAIN_A_SIMD_TAG:-latest}"
export CHAIN_A_SIMD_IMAGE="${CHAIN_A_SIMD_IMAGE:-ibc-go-simd}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed changing these env vars in a previous PR.

@chatton chatton marked this pull request as ready for review August 15, 2022 12:14
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! :)

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean work!

@chatton chatton enabled auto-merge (squash) August 16, 2022 08:32
@chatton chatton merged commit b85c80f into main Aug 16, 2022
@chatton chatton deleted the cian/issue#1964-e2e-failed-token-transfer---receiver-address-is-not-valid branch August 16, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E: Failed token transfer - receiver address is not valid
4 participants