Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: msg types for fee middleware #1572

Merged
merged 14 commits into from
Jun 27, 2022
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/.vuepress/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ module.exports = {
title: "IBC Middleware Modules",
children: [
{
title: "ICS29 Fee Middleware",
title: "Fee Middleware",
Copy link
Member

@damiannolan damiannolan Jun 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this new page to the children array! I think you'll need to merge main first

directory: true,
path: "/middleware",
children: [
Expand All @@ -239,6 +239,10 @@ module.exports = {
path: "/middleware/ics29-fee/integration.html"
},
{
title: "Fee Messages",
directory: false,
path: "/middleware/ics29-fee/msgs.html"
}
title: "Fee Distribution",
directory: false,
path: "/middleware/ics29-fee/fee-distribution.html"
Expand Down
63 changes: 63 additions & 0 deletions docs/middleware/ics29-fee/msgs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
<!--
order: 3
-->

# Escrowing fees

The fee middleware module exposes two different ways to pay fees for relaying IBC packets:

1. `MsgPayPacketFee`, which enables the escrowing of fees for a packet at the next sequence send and should be combined into one `MultiMsgTx` with the message that will be paid for.

Note that the `Relayers` field has been set up to allow for an optional whitelist of relayers permitted to receive this fee, however, this feature has not yet been enabled at this time.

```
type MsgPayPacketFee struct{
Fee Fee
SourcePortId string
SourceChannelId string
Signer string
Relayers []string
}
```

The `Fee` message contained in this synchronous fee payment method configures different fees which will be paid out for `MsgRecvPacket`, `MsgAcknowledgement`, and `MsgTimeout`/`MsgTimeoutOnClose`.

```
type Fee struct {
RecvFee types.Coins
AckFee types.Coins
TimeoutFee types.Coin`
}
```

2. `MsgPayPacketFeeAsync`, which enables the asynchronous escrowing of fees for a specified packet:

```
type MsgPayPacketFeeAsync struct {
PacketId channeltypes.PacketId
PacketFee PacketFee
}
```

where the `PacketFee` also specifies the `Fee` to be paid as well as the refund address for fees which are not paid out
```
type PacketFee struct {
Fee Fee
RefundAddress string
Relayers []]string
}
```

Please see our [wiki](https://github.com/cosmos/ibc-go/wiki/Fee-enabled-fungible-token-transfers) for example flows on how to use these messages to incentivise a token transfer channel.

# Paying out the escrowed fees

In the case of a successful transaction, `RecvFee` will be paid out to the designated counterparty payee address which has been registered on the receiver chain and sent back with the `MsgAcknowledgement`, `AckFee` will be paid out to the relayer address which has submitted the `MsgAcknowledgement` on the sending chain (or the registered payee in case one has been registered for the relayer address), and `TimeoutFee` will be reimbursed to the account which escrowed the fee. In cases of timeout transactions, `RecvFee` and `AckFee` will be reimbursed.

Please note that fee payments are built on the assumption that sender chains are the source of incentives — the chain that sends the packets is the same chain where fee payments will occur -- please see the [relayer operator section](../ics29-fee/fee-distribution.md) to understand the flow for registering payee and counterparty payee (fee receiving) addresses.

# A locked fee middleware module
crodriguezvega marked this conversation as resolved.
Show resolved Hide resolved

The fee middleware module can become locked if the situation arises that the escrow account for the fees does not have sufficient funds to pay out the fees which have been escrowed for each packet. This situation indicates a severe bug. In this case, the fee module will be locked until manual intervention fixes the issue.

A locked fee module will simply skip fee logic and continue on to the underlying packet flow. A channel with a locked fee module will temporarily function as a fee disabled channel, and the locking of a fee module will not affect the continued flow of packets over the channel.