Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto nits #740

Closed
6 tasks
seantking opened this issue Jan 17, 2022 · 2 comments
Closed
6 tasks

Proto nits #740

seantking opened this issue Jan 17, 2022 · 2 comments
Labels
29-fee
Milestone
Fee middleware alpha

Comments

@seantking
Copy link
Contributor

seantking commented Jan 17, 2022 •
edited
Loading

Summary of Issue

  • Nit: Protos - spacing between package, imports, option
  • Nit: rename receive_fee to recv_fee in IdentifiedPacketFee
  • Nit: in proto definition for MsgRegisterCounterpartyAddress, the definition comment has “counter party”, but this should be one word “counterparty”

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking added this to the Fee Middleware milestone Jan 17, 2022
@seantking seantking mentioned this issue Jan 17, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to In review in ibc-go Jan 17, 2022
@colin-axner
Copy link
Contributor

I'd prefer the second nit to have its own pr

@seantking
Copy link
Contributor Author

Cool :) Happy to see someone else wants to split up the work as small as possible. I have the work done already as part of this PR though -> #739

Repository owner moved this from In review to Done in ibc-go Jan 25, 2022
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@ethanfrey
Merge pull request cosmos#740 from CosmWasm/minor_integration_support
4944454 
Minor integration support
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@nashqueue @Manav-Aggarwal
Update dependecy graph (cosmos#740)
11a7f6d 
The highlights of the new dependency graph are a starting sequencer
section, credible neutrality, fraud-proof extension and resolving
software dependencies.

---------

Co-authored-by: Manav Aggarwal <[email protected]>
Co-authored-by: Ganesha Upadhyaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
3 participants
@crodriguezvega @seantking @colin-axner