Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MsgProvideCounterparty to MsgCreateChannel #7334

Closed
4 tasks
DimitrisJim opened this issue Sep 24, 2024 · 2 comments
Closed
4 tasks

Rename MsgProvideCounterparty to MsgCreateChannel #7334

DimitrisJim opened this issue Sep 24, 2024 · 2 comments
Assignees
@DimitrisJim
Labels
core feat: ibc-eureka type: improvement User-facing improvements of an existing feature

Comments

@DimitrisJim
Copy link
Contributor

Raised during aliasing walkthrough.

Could be done after #7333

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@DimitrisJim DimitrisJim added core type: improvement User-facing improvements of an existing feature labels Sep 24, 2024
@AdityaSripal AdityaSripal added this to IBC Sep 30, 2024
@AdityaSripal AdityaSripal self-assigned this Sep 30, 2024
@AdityaSripal
Copy link
Member

Split this into two messages.

MsgCreateChannel which will just set the underlying client id and merkle prefix; and then RegisterCounterparty in a second message which will set the counterparty channel id

@DimitrisJim DimitrisJim moved this to In Progress 👷 in IBC Eureka Oct 2, 2024
@DimitrisJim DimitrisJim moved this to In progress in IBC Oct 2, 2024
@DimitrisJim DimitrisJim removed the status in IBC Eureka Oct 2, 2024
@DimitrisJim DimitrisJim mentioned this issue Oct 2, 2024
Merged
10 tasks
@DimitrisJim
Copy link
Contributor Author

Split is now done. See mentioned PR.

@github-project-automation github-project-automation bot moved this to Done 🥳 in IBC Eureka Oct 10, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in IBC Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
core feat: ibc-eureka type: improvement User-facing improvements of an existing feature
Projects
IBC
Status: Done
IBC Eureka
Status: Done 🥳
Milestone
No milestone
Development

No branches or pull requests
3 participants
@damiannolan @DimitrisJim @AdityaSripal