Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Counterparty to ChannelV2 #7333

Closed
4 tasks
DimitrisJim opened this issue Sep 24, 2024 · 1 comment
Closed
4 tasks

Rename Counterparty to ChannelV2 #7333

DimitrisJim opened this issue Sep 24, 2024 · 1 comment
Assignees
@DimitrisJim
Labels
core feat: ibc-eureka type: improvement User-facing improvements of an existing feature

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Sep 24, 2024 •
edited by AdityaSripal
Loading

Raised during aliasing walkthrough.

Rename the Counterparty type into a ChannelV2.

Additional note here is moving this type into a channel/v2 folder.

proto: channel/v2 folder to create new version of channel instead of counterparty in packetserver folder

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@DimitrisJim DimitrisJim added core type: improvement User-facing improvements of an existing feature labels Sep 24, 2024
@DimitrisJim DimitrisJim mentioned this issue Sep 24, 2024
Closed
4 tasks
@AdityaSripal AdityaSripal added this to IBC Sep 30, 2024
@DimitrisJim DimitrisJim self-assigned this Oct 3, 2024
@damiannolan
Copy link
Contributor

damiannolan commented Oct 9, 2024 •
edited
Loading

Seems to be partially handled in #7429

Happy to pick this up for the channel/v2 pkg myself, unless you were planning on it @DimitrisJim? Let me know if its cool! edit: missed dms on slack, happy to leave it to yourself or aditya if its already in progress

@damiannolan damiannolan mentioned this issue Oct 9, 2024
Merged
10 tasks
@github-project-automation github-project-automation bot moved this to Done 🥳 in IBC Eureka Oct 10, 2024
@github-project-automation github-project-automation bot moved this to Done in IBC Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
core feat: ibc-eureka type: improvement User-facing improvements of an existing feature
Projects
IBC
Status: Done
IBC Eureka
Status: Done 🥳
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damiannolan @DimitrisJim