Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrInvalidChannelFlow tests for ica submodules #550

Closed
3 tasks
damiannolan opened this issue Nov 18, 2021 · 0 comments
Closed
3 tasks

ErrInvalidChannelFlow tests for ica submodules #550

damiannolan opened this issue Nov 18, 2021 · 0 comments
Assignees
@colin-axner
Labels
27-interchain-accounts good first issue Good for newcomers testing Testing package and unit/integration tests
Milestone
Interchain Accounts

Comments

@damiannolan
Copy link
Member

Summary

Interchain accounts is now structured as two distinct submodules controller and host.
Each submodule returns a new error ErrInvalidChannelFlow from callback functions defined within their respective ibc_module.go files.

Tests are required for all callbacks which now return the error mentioned above, asserting the errors are returned from each submodule on the appropriate callbacks.
ChanOpenInit, ChanOpenAck, Timeout/Ack...etc

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added good first issue Good for newcomers testing Testing package and unit/integration tests 27-interchain-accounts labels Nov 18, 2021
@damiannolan damiannolan added this to the Interchain Accounts milestone Nov 18, 2021
@damiannolan damiannolan self-assigned this Nov 19, 2021
@colin-axner colin-axner mentioned this issue Nov 19, 2021
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Done in ibc-go Dec 30, 2021
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@alpe
Merge pull request cosmos#550 from CosmWasm/increase-default-wasm-size
273b57a 
Multiply default wasm size by 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
27-interchain-accounts good first issue Good for newcomers testing Testing package and unit/integration tests
Projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

No branches or pull requests
2 participants
@damiannolan @colin-axner