Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy governance v1beta1 proposal handlers #3674

Closed
2 tasks done
Tracked by #1282
crodriguezvega opened this issue May 28, 2023 · 4 comments
Closed
2 tasks done
Tracked by #1282

Remove legacy governance v1beta1 proposal handlers #3674

crodriguezvega opened this issue May 28, 2023 · 4 comments
Labels
02-client change: api breaking Issues or PRs that break Go API (need to be release in a new major version)
Milestone
v8.0.0

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented May 28, 2023 •
edited by charleenfei
Loading

Part of #1282.

Pre-requisites:

Overview of changes:
@crodriguezvega crodriguezvega added needs discussion Issues that need discussion before they can be worked on 02-client change: api breaking Issues or PRs that break Go API (need to be release in a new major version) labels May 28, 2023
@crodriguezvega crodriguezvega added this to the v8.0.0 milestone May 28, 2023
@colin-axner
Copy link
Contributor

We should migrate the proposals to messages first right? Maybe we can add those issues as pre reqs?

@crodriguezvega crodriguezvega mentioned this issue Jun 24, 2023
Closed
8 tasks
@crodriguezvega
Copy link
Contributor Author

@womensrights verified that relayers are not using the CLI commands so we can remove them.

@crodriguezvega crodriguezvega removed the needs discussion Issues that need discussion before they can be worked on label Jul 17, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 17, 2023
@crodriguezvega crodriguezvega moved this from Todo to On hold in ibc-go Aug 17, 2023
@colin-axner
Copy link
Contributor

What's the benefit of marking protos as deprecated as opposed to removing entirely? I don't think we have an rpc for submitting the legacy proposal?

This was referenced Sep 5, 2023
Merged
Merged
@colin-axner
Copy link
Contributor

removed by #4581 and #4602, will be merged to main by #4620, migration docs will be handled by #4544

@github-project-automation github-project-automation bot moved this from On hold to Done in ibc-go Sep 11, 2023
mmsqe added a commit to yihuang/cronos that referenced this issue Apr 12, 2024
@mmsqe
recover client
9f21d45 
for more info, cosmos/ibc-go#3674
yihuang added a commit to yihuang/cronos that referenced this issue Apr 15, 2024
@yihuang
Problem: parallel tx execution not integrated
ff1f018 
Solution:
- update ethermint and dependencies
- fix sdk 50 integration

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

recover client

for more info, cosmos/ibc-go#3674

fix ibc

for more info, https://ibc.cosmos.network/main/migrations/v7-to-v8#params-migration
yihuang added a commit to yihuang/cronos that referenced this issue Apr 15, 2024
@yihuang
Problem: parallel tx execution not integrated
455f90e 
Solution:
- update ethermint and dependencies
- fix sdk 50 integration

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

recover client

for more info, cosmos/ibc-go#3674

fix ibc

for more info, https://ibc.cosmos.network/main/migrations/v7-to-v8#params-migration
yihuang added a commit to yihuang/cronos that referenced this issue Apr 15, 2024
@yihuang
Problem: parallel tx execution not integrated
72394ab 
Solution:
- update ethermint and dependencies
- fix sdk 50 integration

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

recover client

for more info, cosmos/ibc-go#3674

fix ibc

for more info, https://ibc.cosmos.network/main/migrations/v7-to-v8#params-migration

update deps

fix app hash mismatch

cleanup send_enable test
github-merge-queue bot pushed a commit to crypto-org-chain/cronos that referenced this issue Apr 15, 2024
@yihuang
Problem: parallel tx execution not integrated (#1377)
eda35d7 
Solution:
- update ethermint and dependencies
- fix sdk 50 integration

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

recover client

for more info, cosmos/ibc-go#3674

fix ibc

for more info, https://ibc.cosmos.network/main/migrations/v7-to-v8#params-migration

update deps

fix app hash mismatch

cleanup send_enable test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02-client change: api breaking Issues or PRs that break Go API (need to be release in a new major version)
Projects
ibc-go
Archived in project
Milestone
v8.0.0
Development

No branches or pull requests
2 participants
@crodriguezvega @colin-axner