Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeneratePortId should be in types package #297

Closed
3 tasks
colin-axner opened this issue Jul 26, 2021 · 0 comments
Closed
3 tasks

GeneratePortId should be in types package #297

colin-axner opened this issue Jul 26, 2021 · 0 comments
Labels
27-interchain-accounts good first issue Good for newcomers
Milestone
Interchain Accounts

Comments

@colin-axner
Copy link
Contributor

Summary

GeneratePortId should be stateless and thus in the types package. It should have tests as well

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the good first issue Good for newcomers label Jul 26, 2021
@colin-axner colin-axner added this to the Interchain Accounts milestone Jul 26, 2021
@colin-axner colin-axner mentioned this issue Aug 6, 2021
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Done in ibc-go Dec 30, 2021
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Mar 1, 2022
@jackzampolin
Add defensive key checks per cosmos#297
8e98903
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Mar 1, 2022
@jackzampolin @colin-axner @michaelfig
Merge PR cosmos#318: Update to Cosmos v0.40.0-rc2, relayer v1.0.0-rc0
cb47e65 
* WIP contextual codecs

* Push changes

* WIP

* Merge PR cosmos#319: Remove GetSignBytes usage

* Merge PR cosmos#314: Fix timeout determination

* fix mutex

* fix timeout bug

* fix GetSignBytes

* address other calls to GetSignBytes

Co-authored-by: Jack Zampolin <[email protected]>

* Working version

* Update retries for better errors

* Update import paths and address cosmos#292

* Address cosmos#293

* Address cosmos#295

* Address cosmos#315

* Add defensive key checks per cosmos#297

* Add flags for timeout offsets

* Update retries to have better and more explainatory errors

* WIP acks

* Update to remove replace

* update to sdk master

* Update sdk and make changes

* WIP timeouts and acks, strategy refactor

* WIP cleanup

* update to v0.40.0-rc2

* Refactor path generation and status

* Merge PR cosmos#274: feat: allow building a shared library

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Michael FIG <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
27-interchain-accounts good first issue Good for newcomers
Projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

No branches or pull requests
2 participants
@crodriguezvega @colin-axner