Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICA Code Coverage #279

Closed
4 tasks done
seantking opened this issue May 28, 2021 · 1 comment · Fixed by #337
Closed
4 tasks done

ICA Code Coverage #279

seantking opened this issue May 28, 2021 · 1 comment · Fixed by #337

Comments

@seantking
Copy link
Contributor

seantking commented May 28, 2021

@colin-axner colin-axner transferred this issue from cosmos/interchain-accounts-demo Jul 21, 2021
@colin-axner colin-axner changed the title Code Coverage ICA Code Coverage Jul 21, 2021
@colin-axner colin-axner added this to the Interchain Accounts milestone Jul 21, 2021
@colin-axner
Copy link
Contributor

colin-axner commented Jul 21, 2021

Within types files which need tests:

  • account.go
  • genesis.go (needs basic validation logic as well)
  • hook.go
  • packet.go

Within keeper files which need tests:

  • account.go
  • grpc_query.go
  • handshake.go
  • keeper.go
  • relay.go

Top level files which need tests:

  • module.go (ibc callbacks)
  • genesis.go

CLI tests are difficult to do for IBC due to the structure of in-process app testing. CLI tests are very low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants