Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump package to v4 #1359

Closed
crodriguezvega opened this issue May 16, 2022 · 0 comments · Fixed by #1564
Closed

Bump package to v4 #1359

crodriguezvega opened this issue May 16, 2022 · 0 comments · Fixed by #1564
Assignees
@crodriguezvega
Milestone
v4.0.0

Comments

@crodriguezvega
Copy link
Contributor

We are going to release fee middleware as v4, and since it contains an API breaking change and we follow go semantic versioning, then we need to bump our package. The go.mod file will read:

module github.com/cosmos/ibc-go/v4

All imports will need to change.
@crodriguezvega crodriguezvega changed the title bump package to v4 Bump package to v4 May 16, 2022
@crodriguezvega crodriguezvega added this to the v4.0.0 milestone May 16, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go May 16, 2022
@crodriguezvega crodriguezvega self-assigned this Jun 22, 2022
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Jun 22, 2022
@crodriguezvega crodriguezvega mentioned this issue Jun 22, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega linked a pull request Jun 22, 2022 that will close this issue
chore: bump go package version to v4 #1564
Merged
9 tasks
crodriguezvega pushed a commit that referenced this issue Jun 26, 2022
Merge branch 'main' into carlos/#1359-bump-package-to-v4
297018c
crodriguezvega pushed a commit that referenced this issue Jun 27, 2022
Merge branch 'main' into carlos/#1359-bump-package-to-v4
b0b5f02
crodriguezvega pushed a commit that referenced this issue Jun 27, 2022
Merge branch 'main' into carlos/#1359-bump-package-to-v4
1ce40be
crodriguezvega pushed a commit that referenced this issue Jun 28, 2022
Merge branch 'main' into carlos/#1359-bump-package-to-v4
18536b5
crodriguezvega pushed a commit that referenced this issue Jun 29, 2022
Merge branch 'carlos/#1359-bump-package-to-v4' of https://github.com/…
2738f86 
…cosmos/ibc-go into carlos/#1359-bump-package-to-v4

# Conflicts:
#	modules/apps/29-fee/keeper/escrow_test.go
crodriguezvega pushed a commit that referenced this issue Jun 29, 2022
Merge branch 'main' into carlos/#1359-bump-package-to-v4
7cdbae5 
# Conflicts:
#	modules/apps/27-interchain-accounts/host/types/ack.go
#	modules/apps/27-interchain-accounts/host/types/ack_test.go
#	modules/apps/transfer/ibc_module.go
#	modules/apps/transfer/types/ack.go
#	modules/apps/transfer/types/ack_test.go
#	modules/core/04-channel/types/acknowledgement_test.go
crodriguezvega pushed a commit that referenced this issue Jun 29, 2022
Merge branch 'main' into carlos/#1359-bump-package-to-v4
12de037 
# Conflicts:
#	modules/apps/27-interchain-accounts/host/types/ack_test.go
#	modules/apps/transfer/ibc_module.go
#	modules/apps/transfer/types/ack_test.go
Repository owner moved this from In progress to Done in ibc-go Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
None yet
Projects
ibc-go
Archived in project
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

chore: bump go package version to v4 cosmos/ibc-go
1 participant
@crodriguezvega