imp(ica_test): improved tests without type assertion

cosmos · Aug 1, 2023 · fbcf8b7 · fbcf8b7
1 parent 11a859a
commit fbcf8b7
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/modules/apps/27-interchain-accounts/types/packet_test.go b/modules/apps/27-interchain-accounts/types/packet_test.go
@@ -92,7 +92,7 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
 	testCases := []struct {
 		name          string
 		packetData    types.InterchainAccountPacketData
-		expCustomData map[string]interface{}
+		expCustomData interface{}
 	}{
 		{
 			"success: src_callback key in memo",
@@ -118,37 +118,36 @@ func (suite *TypesTestSuite) TestPacketDataProvider() {
 			},
 		},
 		{
-			"failure: empty memo",
+			"success: src_callback has string valu",
 			types.InterchainAccountPacketData{
 				Type: types.EXECUTE_TX,
 				Data: []byte("data"),
-				Memo: "",
+				Memo: `{"src_callback": "string"}`,
 			},
-			nil,
+			"string",
 		},
 		{
-			"failure: non-json memo",
+			"failure: empty memo",
 			types.InterchainAccountPacketData{
 				Type: types.EXECUTE_TX,
 				Data: []byte("data"),
-				Memo: "invalid",
+				Memo: "",
 			},
 			nil,
 		},
 		{
-			"failure: invalid src_callback key",
+			"failure: non-json memo",
 			types.InterchainAccountPacketData{
 				Type: types.EXECUTE_TX,
 				Data: []byte("data"),
-				Memo: `{"src_callback": "invalid"}`,
+				Memo: "invalid",
 			},
 			nil,
 		},
 	}
 
 	for _, tc := range testCases {
-		additionalData, ok := tc.packetData.GetCustomPacketData("src_callback").(map[string]interface{})
-		suite.Require().Equal(ok, additionalData != nil)
-		suite.Require().Equal(tc.expCustomData, additionalData)
+		customData := tc.packetData.GetCustomPacketData("src_callback")
+		suite.Require().Equal(tc.expCustomData, customData)
 	}
 }