Skip to content

Commit

Permalink
fix comments (#6628)
Browse files Browse the repository at this point in the history
  • Loading branch information
winniehere authored and bznein committed Jun 18, 2024
1 parent ef2b01b commit ef5b196
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
5 changes: 3 additions & 2 deletions modules/apps/29-fee/types/query.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/apps/callbacks/testing/simapp/contract_keeper.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func NewContractKeeper(key storetypes.StoreKey) *ContractKeeper {
return k
}

// IBCPacketSendCallback increments the stateful entry counter and the send_packet callback counter.
// IBCSendPacketCallback increments the stateful entry counter and the send_packet callback counter.
// This function:
// - returns MockApplicationCallbackError and consumes half the remaining gas if the contract address is ErrorContract
// - Oog panics and consumes all the remaining gas + 1 if the contract address is OogPanicContract
Expand Down
2 changes: 1 addition & 1 deletion modules/apps/transfer/internal/events/events.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func EmitOnAcknowledgementPacketEvent(ctx sdk.Context, packetData types.Fungible
}
}

// EmitOnTimeoutPacketEvent emits a fungible token packet event in the OnTimeoutPacket callback
// EmitOnTimeoutEvent emits a fungible token packet event in the OnTimeoutPacket callback
func EmitOnTimeoutEvent(ctx sdk.Context, packetData types.FungibleTokenPacketDataV2) {
jsonTokens := mustMarshalType[types.Tokens](types.Tokens(packetData.Tokens))

Expand Down
2 changes: 1 addition & 1 deletion modules/core/02-client/migrations/v7/store_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func (suite *MigrationsV7TestSuite) createLocalhostClients() {
}
}

// assertLocalhostClients asserts that all localhost information has been deleted
// assertNoLocalhostClients asserts that all localhost information has been deleted
func (suite *MigrationsV7TestSuite) assertNoLocalhostClients() {
for numClients := uint64(0); numClients < numCreations; numClients++ {
clientID := v7.Localhost + "-" + strconv.FormatUint(numClients, 10)
Expand Down
5 changes: 3 additions & 2 deletions proto/ibc/applications/fee/v1/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ message QueryIncentivizedPacketRequest {
uint64 query_height = 2;
}

// QueryIncentivizedPacketsResponse defines the response type for the IncentivizedPacket rpc
// QueryIncentivizedPacketResponse defines the response type for the IncentivizedPacket rpc
message QueryIncentivizedPacketResponse {
// the identified fees for the incentivized packet
ibc.applications.fee.v1.IdentifiedPacketFees incentivized_packet = 1 [(gogoproto.nullable) = false];
Expand All @@ -112,7 +112,8 @@ message QueryIncentivizedPacketsForChannelRequest {
uint64 query_height = 4;
}

// QueryIncentivizedPacketsResponse defines the response type for the incentivized packets RPC
// QueryIncentivizedPacketsForChannelResponse defines the response type for querying for all incentivized packets
// for a specific channel
message QueryIncentivizedPacketsForChannelResponse {
// Map of all incentivized_packets
repeated ibc.applications.fee.v1.IdentifiedPacketFees incentivized_packets = 1;
Expand Down

0 comments on commit ef5b196

Please sign in to comment.