fix: rm bech32 check from owner address on ICA controller msgs Regist…

…erInterchainAccount and SendTx (#2601) * rm validate basic owner address check
cosmos · Oct 31, 2022 · e8ff311 · e8ff311
1 parent 623e593
commit e8ff311
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 22 deletions.
diff --git a/modules/apps/27-interchain-accounts/controller/types/msgs.go b/modules/apps/27-interchain-accounts/controller/types/msgs.go
@@ -31,10 +31,6 @@ func (msg MsgRegisterInterchainAccount) ValidateBasic() error {
 		return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, "owner address cannot be empty")
 	}
 
-	if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil {
-		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner)
-	}
-
 	return nil
 }
 
@@ -68,10 +64,6 @@ func (msg MsgSendTx) ValidateBasic() error {
 		return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, "owner address cannot be empty")
 	}
 
-	if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil {
-		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner)
-	}
-
 	if err := msg.PacketData.ValidateBasic(); err != nil {
 		return sdkerrors.Wrap(err, "invalid interchain account packet data")
 	}

diff --git a/modules/apps/27-interchain-accounts/controller/types/msgs_test.go b/modules/apps/27-interchain-accounts/controller/types/msgs_test.go
@@ -62,13 +62,6 @@ func TestMsgRegisterInterchainAccountValidateBasic(t *testing.T) {
 			},
 			false,
 		},
-		{
-			"owner address is invalid",
-			func() {
-				msg.Owner = "invalid_address"
-			},
-			false,
-		},
 	}
 
 	for i, tc := range testCases {
@@ -125,13 +118,6 @@ func TestMsgSendTxValidateBasic(t *testing.T) {
 			},
 			false,
 		},
-		{
-			"owner address is invalid",
-			func() {
-				msg.Owner = "invalid_address"
-			},
-			false,
-		},
 		{
 			"relative timeout is not set",
 			func() {