Skip to content

Commit

Permalink
Merge branch 'main' into dependabot/github_actions/JamesIves/github-p…
Browse files Browse the repository at this point in the history
…ages-deploy-action-4.7.1
  • Loading branch information
damiannolan authored Nov 30, 2024
2 parents 2124373 + 121f1fb commit 9cdf82b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion modules/apps/callbacks/types/types_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
ibctesting "github.com/cosmos/ibc-go/v9/testing"
)

// CallbacksTestSuite defines the needed instances and methods to test callbacks
// CallbacksTypesTestSuite defines the needed instances and methods to test callbacks
type CallbacksTypesTestSuite struct {
suite.Suite

Expand Down
6 changes: 3 additions & 3 deletions testing/coordinator.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ func (*Coordinator) SetupClients(path *Path) {
path.SetupClients()
}

// SetupClientConnections is a helper function to create clients and the appropriate
// SetupConnections is a helper function to create clients and the appropriate
// connections on both the source and counterparty chain. It assumes the caller does not
// anticipate any errors.
// Deprecated: please use path.SetupConnections(), this function will be removed in v10
func (*Coordinator) SetupConnections(path *Path) {
path.SetupConnections()
}

// CreateConnection constructs and executes connection handshake messages in order to create
// CreateConnections constructs and executes connection handshake messages in order to create
// OPEN channels on chainA and chainB. The connection information of for chainA and chainB
// are returned within a TestConnection struct. The function expects the connections to be
// successfully opened otherwise testing will fail.
Expand Down Expand Up @@ -123,7 +123,7 @@ func (*Coordinator) CreateTransferChannels(path *Path) {
path.CreateChannels()
}

// CreateChannel constructs and executes channel handshake messages in order to create
// CreateChannels constructs and executes channel handshake messages in order to create
// OPEN channels on chainA and chainB. The function expects the channels to be successfully
// opened otherwise testing will fail.
// Deprecated: please use path.CreateChannels(), this function will be removed in v10
Expand Down
2 changes: 1 addition & 1 deletion testing/endpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ func (endpoint *Endpoint) AcknowledgePacket(packet channeltypes.Packet, ack []by
return endpoint.Chain.sendMsgs(ackMsg)
}

// AcknowledgePacket sends a MsgAcknowledgement to the channel associated with the endpoint and returns the result.
// AcknowledgePacketWithResult sends a MsgAcknowledgement to the channel associated with the endpoint and returns the result.
func (endpoint *Endpoint) AcknowledgePacketWithResult(packet channeltypes.Packet, ack []byte) (*abci.ExecTxResult, error) {
// get proof of acknowledgement on counterparty
packetKey := host.PacketAcknowledgementKey(packet.GetDestPort(), packet.GetDestChannel(), packet.GetSequence())
Expand Down

0 comments on commit 9cdf82b

Please sign in to comment.