chore(api)!: Remove unnecessary event attribute from INIT Handshake Msgs

cosmos · Jun 30, 2023 · 99e1d7e · 99e1d7e
1 parent a88fc76
commit 99e1d7e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 2 deletions.
diff --git a/docs/migrations/v7-to-v8.md b/docs/migrations/v7-to-v8.md
@@ -83,6 +83,7 @@ TODO:
 ## Relayers
 
 - Getter functions in `MsgChannelOpenInitResponse`, `MsgChannelOpenTryResponse`, `MsgTransferResponse`, `MsgRegisterInterchainAccountResponse` and `MsgSendTxResponse` have been removed. The fields can be accessed directly.
+- Attribute with key `counterparty_connection_id` has been removed from event with key `connectiontypes.EventTypeConnectionOpenInit` (where `connectiontypes` is an import alias for `"github.com/cosmos/ibc-go/v8/modules/core/03-connection/types"`) and attribute with key `counterparty_channel_id` has been removed from event with key `channeltypes.EventTypeChannelOpenInit` (where `channeltypes` is an import alias for `"github.com/cosmos/ibc-go/v8/modules/core/04-channel"`) since both (counterparty connection ID and counterparty channel ID) are empty on `ConnectionOpenInit` and `ChannelOpenInit` respectively. 
 
 ## IBC Light Clients
 

diff --git a/modules/core/03-connection/keeper/events.go b/modules/core/03-connection/keeper/events.go
@@ -14,7 +14,6 @@ func emitConnectionOpenInitEvent(ctx sdk.Context, connectionID string, clientID
 			sdk.NewAttribute(types.AttributeKeyConnectionID, connectionID),
 			sdk.NewAttribute(types.AttributeKeyClientID, clientID),
 			sdk.NewAttribute(types.AttributeKeyCounterpartyClientID, counterparty.ClientId),
-			sdk.NewAttribute(types.AttributeKeyCounterpartyConnectionID, counterparty.ConnectionId),
 		),
 		sdk.NewEvent(
 			sdk.EventTypeMessage,

diff --git a/modules/core/04-channel/keeper/events.go b/modules/core/04-channel/keeper/events.go
@@ -18,7 +18,6 @@ func emitChannelOpenInitEvent(ctx sdk.Context, portID string, channelID string,
 			sdk.NewAttribute(types.AttributeKeyPortID, portID),
 			sdk.NewAttribute(types.AttributeKeyChannelID, channelID),
 			sdk.NewAttribute(types.AttributeCounterpartyPortID, channel.Counterparty.PortId),
-			sdk.NewAttribute(types.AttributeCounterpartyChannelID, channel.Counterparty.ChannelId),
 			sdk.NewAttribute(types.AttributeKeyConnectionID, channel.ConnectionHops[0]),
 			sdk.NewAttribute(types.AttributeVersion, channel.Version),
 		),