Merge branch 'main' into tulasi/expectErrors/23-commitment/types

modules/apps/transfer/keeper/keeper.go

@@ -359,18 +359,18 @@ func (k Keeper) iterateForwardedPackets(ctx context.Context, cb func(packet type
 		// Iterator key consists of types.ForwardedPacketKey/portID/channelID/sequence
 		parts := strings.Split(string(iterator.Key()), "/")
 		if len(parts) != 4 {
-			panic(fmt.Errorf("key path should always have 4 elements"))
+			panic(errors.New("key path should always have 4 elements"))
 		}
 		if parts[0] != string(types.ForwardedPacketKey) {
 			panic(fmt.Errorf("key path does not start with expected prefix: %s", types.ForwardedPacketKey))
 		}
 
 		portID, channelID := parts[1], parts[2]
 		if err := host.PortIdentifierValidator(portID); err != nil {
-			panic(fmt.Errorf("port identifier validation failed while parsing forward key path"))
+			panic(errors.New("port identifier validation failed while parsing forward key path"))
 		}
 		if err := host.ChannelIdentifierValidator(channelID); err != nil {
-			panic(fmt.Errorf("channel identifier validation failed while parsing forward key path"))
+			panic(errors.New("channel identifier validation failed while parsing forward key path"))
 		}
 
 		forwardPacket.ForwardKey.Sequence = sdk.BigEndianToUint64([]byte(parts[3]))

modules/core/04-channel/keeper/keeper_test.go

@@ -915,7 +915,7 @@ func (suite *KeeperTestSuite) UpgradeChannel(path *ibctesting.Path, upgradeField
 	suite.Require().NoError(err)
 }
 
-// sendMockPacket sends a packet from source to dest and acknowledges it on the source (completing the packet lifecycle)
+// sendMockPackets sends a packet from source to dest and acknowledges it on the source (completing the packet lifecycle)
 // if acknowledge is true. If acknowledge is false, then the packet will be sent, but timed out.
 // Question(jim): find a nicer home for this?
 func (suite *KeeperTestSuite) sendMockPackets(path *ibctesting.Path, numPackets int, acknowledge bool) {

modules/light-clients/08-wasm/internal/types/store.go

@@ -151,7 +151,7 @@ func (s ClientRecoveryStore) CacheWrapWithTrace(w io.Writer, tc storetypes.Trace
 	return cachekv.NewStore(tracekv.NewStore(s, w, tc))
 }
 
-// getStore returns the types to be used for the given key and a boolean flag indicating if that types was found.
+// GetStore returns the types to be used for the given key and a boolean flag indicating if that type was found.
 // If the key is prefixed with "subject/", the subjectStore is returned. If the key is prefixed with "substitute/",
 // the substituteStore is returned.
 //

modules/light-clients/08-wasm/keeper/keeper.go

@@ -72,7 +72,7 @@ func (k Keeper) getQueryPlugins() QueryPlugins {
 	return k.queryPlugins
 }
 
-// SetQueryPlugins sets the plugins.
+// setQueryPlugins sets the plugins.
 func (k *Keeper) setQueryPlugins(plugins QueryPlugins) {
 	k.queryPlugins = plugins
 }