fix: working hash with initial version #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport release/v1.1.x |
✅ Backports have been created
|
|
@Mergifyio backport master |
✅ Backports have been created
|
tac0turtle
approved these changes
May 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
(cherry picked from commit 70f77c2) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
(cherry picked from commit 70f77c2) # Conflicts: # CHANGELOG.md
cool-develope
added a commit
that referenced
this pull request
May 7, 2024
tac0turtle
pushed a commit
that referenced
this pull request
May 8, 2024
Co-authored-by: cool-developer <[email protected]>
tac0turtle
pushed a commit
that referenced
this pull request
May 8, 2024
Co-authored-by: cool-developer <[email protected]>
roy-dydx
pushed a commit
to dydxprotocol/iavl
that referenced
this pull request
May 9, 2024
roy-dydx
pushed a commit
to dydxprotocol/iavl
that referenced
this pull request
May 9, 2024
roy-dydx
pushed a commit
to dydxprotocol/iavl
that referenced
this pull request
May 9, 2024
1 task
10 tasks
|
This PR seems to be a major breaking change in how root hash is calculated with the initial version. |
This is modified in #676 , yes v1 is a consensus breaking in the edge case, #956 (comment) |
I see, what's interesting is we only notice the difference after the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
InitialVersionis not reflected in theWorkingHashcalculation, only reflected in theSaveVersion. This will lead to theAppHashmismatch while upgrading, since the the hash of the root is already calculated in theWorkingHashand won't re-calculated in theSaveVersionwhich is wrong.