-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: legacy node key #928
fix: legacy node key #928
Conversation
@Mergifyio backport release/v1.x.x |
✅ Backports have been created
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it fixes our app hash issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test case please
_, err = tree.Load() | ||
require.NoError(t, err) | ||
_, err = tree.Set([]byte("key1"), []byte("value2")) | ||
require.NoError(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed that the error is triggered here in the original version. cc: @tac0turtle
tests pass locally, git actions are acting weird |
(cherry picked from commit 0d64869) # Conflicts: # CHANGELOG.md
Co-authored-by: cool-developer <[email protected]>
Context
After reformatting of the pruned root node, it may be referred as a legacy node, since the nonce is 0.