Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: legacy node key #928

Merged
merged 3 commits into from
Apr 8, 2024
Merged

fix: legacy node key #928

merged 3 commits into from
Apr 8, 2024

Conversation

cool-develope
Copy link
Collaborator

Context

After reformatting of the pruned root node, it may be referred as a legacy node, since the nonce is 0.

@cool-develope cool-develope requested a review from a team as a code owner April 5, 2024 17:35
@cool-develope
Copy link
Collaborator Author

@Mergifyio backport release/v1.x.x

Copy link
Contributor

mergify bot commented Apr 5, 2024

backport release/v1.x.x

✅ Backports have been created

Copy link
Contributor

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it fixes our app hash issue

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test case please

_, err = tree.Load()
require.NoError(t, err)
_, err = tree.Set([]byte("key1"), []byte("value2"))
require.NoError(t, err)
Copy link
Collaborator Author

@cool-develope cool-develope Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that the error is triggered here in the original version. cc: @tac0turtle

@tac0turtle
Copy link
Member

tests pass locally, git actions are acting weird

@tac0turtle tac0turtle merged commit 0d64869 into release/v1.1.x Apr 8, 2024
4 of 5 checks passed
@tac0turtle tac0turtle deleted the fix/legacy_nodekey branch April 8, 2024 17:58
mergify bot pushed a commit that referenced this pull request Apr 8, 2024
(cherry picked from commit 0d64869)

# Conflicts:
#	CHANGELOG.md
tac0turtle pushed a commit that referenced this pull request Apr 8, 2024
cool-develope added a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants