-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add skipFastStorageUpgrade
to MutableTree
to control fast storage upgrade
#547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one comment
ea25c74
to
7cb9973
Compare
skipFastStorageUpgrade
to MutableTree
to control fast storage upgradeskipFastStorageUpgrade
to MutableTree
to control fast storage upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we will have to push this to a branch without the cosmos-db changes.
is this not compatible with |
I can handle this part, will start right when this is merged. Would like to get one more review before then |
…l fast storage upgrade (cosmos#547)" This reverts commit fcab556.
Add the
skipFastStorageUpgrade
field toMutalbeTree
.If
skipFastStorageUpgrade
is true, neitherLoad()
,LazyLoadVersion()
,LoadVersion()
norLoadVersionForOverwriting
would try to upgrade fast storage when loading the tree.This is needed for archive nodes with extremely big db to avoid taking unacceptable long time to upgrade the fast storage