reuse buffer #453
Merged
reuse buffer #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
approved these changes
Dec 14, 2021
robert-zaremba
approved these changes
Dec 15, 2021
|
getting a stack overflow in tests, any idea @odeke-em |
I just remembered that some of these functions return a byte slice []byte that'll be alive for who knows how long. However, we return buf.Bytes() which returns the raw underlying buffer. Looks like that's causing the problem. You can fix this by doing what I did here tendermint/tendermint#7325 and it'll still be much cheaper than creating and discarding a bytes.Buffer. |
odeke-em
approved these changes
Dec 16, 2021
prolenking
pushed a commit
to prolenking/iavl
that referenced
this pull request
Aug 9, 2022
* reuse buffer * copy bytes (cherry picked from commit 0568d39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #371
cc @odeke-em