Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export: reduce node buffer to 32 #235

Merged
merged 2 commits into from
Apr 21, 2020
Merged

export: reduce node buffer to 32 #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbee48e
export: reduce node buffer to 32.
erikgrinaker Apr 21, 2020
e15f1b2
Merge branch 'master' into erik/export-buffer-32
mergify[bot] Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion export.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ import (
"github.com/pkg/errors"
)

// exportBufferSize is the number of nodes to buffer in the exporter. It improves throughput by
// processing multiple nodes per context switch, but take care to avoid excessive memory usage,
// especially since callers may export several IAVL stores in parallel (e.g. the Cosmos SDK).
const exportBufferSize = 32

// ExportDone is returned by Exporter.Next() when all items have been exported.
var ExportDone = errors.New("export is complete") // nolint:golint

Expand Down Expand Up @@ -33,7 +38,7 @@ func newExporter(tree *ImmutableTree) *Exporter {
ctx, cancel := context.WithCancel(context.Background())
exporter := &Exporter{
tree: tree,
ch: make(chan *ExportNode, 64),
ch: make(chan *ExportNode, exportBufferSize),
cancel: cancel,
}

Expand Down