Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to version latest master #86

Merged
merged 10 commits into from
Aug 5, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 2, 2019

Update to the latest master of the SDK.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@alexanderbez
Copy link
Contributor Author

@fedekunze mind tackling the simulation updates?

@alexanderbez alexanderbez changed the title Update SDK to version 861e4798adcb (latest master) Update SDK to version latest master Aug 3, 2019
@fedekunze fedekunze added WIP and removed R4R labels Aug 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #86 into master will decrease coverage by 0.34%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   67.37%   67.03%   -0.35%     
==========================================
  Files           3        3              
  Lines         472      458      -14     
==========================================
- Hits          318      307      -11     
+ Misses        123      120       -3     
  Partials       31       31

@alexanderbez alexanderbez added R4R and removed WIP labels Aug 5, 2019
@alexanderbez alexanderbez merged commit 10cde22 into master Aug 5, 2019
@alexanderbez alexanderbez deleted the bez/update-sdk-861e4798adcb branch August 5, 2019 15:50
@fedekunze fedekunze restored the bez/update-sdk-861e4798adcb branch August 5, 2019 19:05
@fedekunze fedekunze deleted the bez/update-sdk-861e4798adcb branch August 5, 2019 19:09
zmanian added a commit to iqlusioninc/gaia that referenced this pull request May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants