-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK to version latest master #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
alessio,
jackzampolin and
rigelrozanski
as code owners
August 2, 2019 14:31
@fedekunze mind tackling the simulation updates? |
4 tasks
alexanderbez
changed the title
Update SDK to version 861e4798adcb (latest master)
Update SDK to version latest master
Aug 3, 2019
…into bez/update-sdk-861e4798adcb
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 67.37% 67.03% -0.35%
==========================================
Files 3 3
Lines 472 458 -14
==========================================
- Hits 318 307 -11
+ Misses 123 120 -3
Partials 31 31 |
jackzampolin
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest
master
of the SDK.Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [stanza] [message]
Reviewed
Files changed
in the github PR explorerFor Admin Use: