-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SDK with extended module account permissions #67
Update to SDK with extended module account permissions #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although the sims are not running @alessio . @colin-axner we should update the order of the init genesis too here to match the simapp
's one, basically moving supply
between crisis
and mint
Why was dis closed? (just curious) |
#70 got merged instead which had the same changes, but used a different commit for go.mod. This pr probably should have been merged instead, as the other pr was meant to be used for testing with the supply genesis pr that was a WIP at the time. On a different note, I wanted to open #70 as draft originally, but this repo wouldn't let me do so. Is this something we can enable or is there a reason for not allowing this? |
no clue on the drafts... yeah maybe it has to be enabled per repo? (CC @jackzampolin can you do this?) |
Looks like you can do that here @rigelrozanski, no admin needed. |
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [stanza] [message]
Reviewed
Files changed
in the github PR explorerFor Admin Use: