Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SDK with extended module account permissions #67

Closed
wants to merge 2 commits into from
Closed

Update to SDK with extended module account permissions #67

wants to merge 2 commits into from

Conversation

colin-axner
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although the sims are not running @alessio . @colin-axner we should update the order of the init genesis too here to match the simapp's one, basically moving supply between crisis and mint

go.sum Outdated Show resolved Hide resolved
@jackzampolin jackzampolin mentioned this pull request Jul 9, 2019
5 tasks
@rigelrozanski
Copy link
Contributor

Why was dis closed? (just curious)

@colin-axner
Copy link
Contributor Author

#70 got merged instead which had the same changes, but used a different commit for go.mod. This pr probably should have been merged instead, as the other pr was meant to be used for testing with the supply genesis pr that was a WIP at the time.

On a different note, I wanted to open #70 as draft originally, but this repo wouldn't let me do so. Is this something we can enable or is there a reason for not allowing this?

@rigelrozanski
Copy link
Contributor

no clue on the drafts... yeah maybe it has to be enabled per repo? (CC @jackzampolin can you do this?)

@jackzampolin
Copy link
Member

Looks like you can do that here @rigelrozanski, no admin needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants