Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix upgrade test #2680

Merged
merged 2 commits into from
Aug 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions contrib/scripts/upgrade_test_scripts/v12/run_gaia_v11.sh
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
#!/bin/sh

set -o errexit -o nounset
set -x

NODE_HOME=$(realpath ./build/.gaia)
rm -r $NODE_HOME
echo "NODE_HOME = ${NODE_HOME}"
BINARY=$NODE_HOME/cosmovisor/genesis/bin/gaiad
echo "BINARY = ${BINARY}"
Expand Down Expand Up @@ -72,4 +70,4 @@ enable = true/g' $NODE_HOME/config/app.toml
pwd
ls $NODE_HOME

$COSMOVISOR run start --home $NODE_HOME --x-crisis-skip-assert-invariants
$COSMOVISOR run start --home $NODE_HOME --x-crisis-skip-assert-invariants > v11.out 2>&1 &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why > v11.out 2>&1 & was needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not needed, just to keep the same as previous upgrade script.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh
set -x
# set -o errexit -o nounset

set -o errexit -o nounset

UPGRADE_HEIGHT=$1

Expand Down Expand Up @@ -29,8 +29,7 @@ sleep 10
$BINARY config chain-id $CHAINID --home $NODE_HOME
$BINARY config output json --home $NODE_HOME
$BINARY config keyring-backend test --home $NODE_HOME
# $BINARY config --home $NODE_HOME
$BINARY config broadcast-mode block --home $NODE_HOME
$BINARY config --home $NODE_HOME

key=$($BINARY keys show val --home $NODE_HOME)
if [ -z "$key" ]; then
Expand Down