Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: start using unclog on release/v9.1.x #2607

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Jun 16, 2023

Description

Closes: NA

Related to #2604


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed @mmulji-ic Failing tests unrelated to this PR
  • Confirmed that this PR does not change production code

@MSalopek
Copy link
Contributor

Maybe we should start using unclog from versions >= v10.x.x to have a clean cut between versions that have it and ones that don't?

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpoke
Copy link
Contributor Author

mpoke commented Jun 19, 2023

Maybe we should start using unclog from versions >= v10.x.x to have a clean cut between versions that have it and ones that don't?

We'll maintain v9.1.x until v11 will be released. Having different methods to deal with the changelog would make backporting fixes very difficult.

@mpoke mpoke merged commit b54293e into release/v9.1.x Jun 21, 2023
@mpoke mpoke deleted the marius/unclog-v9 branch June 21, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants