-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IAVL fast node #2595
Use IAVL fast node #2595
Conversation
Does this introduce any risks of consensus breaking or can it be put out as a non-coordinated upgrade? Can you post some stats about what the performance increase is? |
The best way is to test it out for yourself, here: https://twitter.com/gadikian/status/1669600575053508613?s=20 As for stats, I can ask Roman on the osmosis team, but I'm not fully sure. There may have been some stats, from a long time ago, the thing I can say for sure is that there was a dramatic improvement in iterator performance. I'll make a PR that demonstrates using it as seen in the video, against the v9.x branch...
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
=======================================
Coverage 85.16% 85.16%
=======================================
Files 23 23
Lines 1604 1604
=======================================
Hits 1366 1366
Misses 192 192
Partials 46 46 |
This can also help with the set of issues outlined in #2635 Keep in mind: when a node is pounded to death over RPC, one thing that happens is that p2p goes down. |
@jtremback -- the benchmarks are... not great or formal. To my knowledge, no one has them. Another reason that this PR is a good idea though, is the fact that it will ensure that we don't run into downtime at the 47 upgrade. Basically, would be good to roll this out across validators while we are still on v10. |
@faddat At the recommendation of the SDK team, we decided not to go ahead with this change. The reason is that node operators are free to change this and many of them already do. |
This PR enables IAVL fast node, and will become more important as more consumer chains are being added.